I'm submitting a ...
- [ ] bug report
- [x] feature request
Current behaviour:
Google Cloud SDK is not present
Expected behaviour:
To integrate Cloud SQL, Google Cloud SDK should be present in the system
Yes, I am working on it
vaibhavsingh97
All 21 comments
@vaibhavsingh97 any updates?
djmgit
on 20 May 2018
@djmgit Facing small issue with GCP, trying to fix it out. due to the problem of the internet in my area, I was not able to found the fix. i will try to send PR for the issues I claimed. sorry for the delay
vaibhavsingh97
on 20 May 2018
As no PR is sent from past two days, Can I send PR for the same @djmgit @harshit98 ?? As the progress of the project should not be stalled :smile:
yashLadha
on 21 May 2018
Yash, I am sending PR shortly
On Tue 22 May, 2018, 12:07 AM Yash Ladha, notifications@github.com wrote:
As no PR is sent from past two days, Can I send PR for the same @djmgit
https://github.com/djmgit @harshit98 https://github.com/harshit98 ??
As the progress of the project should not be stalled 😄—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/badgeyay/issues/797#issuecomment-390743750,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AITVapYkYGrS0mbGjsae-HyxGgpZbe_Sks5t0wl0gaJpZM4UFJIT
.
vaibhavsingh97
on 21 May 2018
Yes @yashLadha, You can go ahead as I think @vaibhavsingh97 has connectivity Issues. Waiting for PR :+1:
ParthS007
on 21 May 2018
@vaibhavsingh97 It's been two days and we haven't seen a PR from your side. It is not a good practice in OSS to hold issue for a long time and not send a PR as this is a community project. Views @djmgit @harshit98
yashLadha
on 21 May 2018
Yash, I am really sorry as due to connectivity issue I was not able to send
PR
On Tue 22 May, 2018, 12:12 AM Yash Ladha, notifications@github.com wrote:
@vaibhavsingh97 https://github.com/vaibhavsingh97 It's been two days
and we haven't seen a PR from your side. It is not a good practice in OSS
to hold issue for a long time and not send a PR as this is a community
project.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/badgeyay/issues/797#issuecomment-390745179,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AITVajuRRFALUMnHxeFUEC7cxKtwDkt8ks5t0wqxgaJpZM4UFJIT
.
vaibhavsingh97
on 21 May 2018
I guess @yashLadha can work on it now.
gabru-md
on 21 May 2018
Sending PR will only cost the bandwidth as sending reply of this mail. Isn't it @vaibhavsingh97
yashLadha
on 21 May 2018
@yashLadha I am able to reply as today My internet connection is good. as you have seen that I was not that active from past 2 days due to connectivity issue
vaibhavsingh97
on 21 May 2018
we don’t need any Google cloud SDK
https://cloud.google.com/sql/docs/postgres/connect-external-app#python
So, We just need to have to invoke proxy to connect to Cloud SQL and also for storing assets we are using Firebase storage
ref: https://github.com/fossasia/badgeyay/issues/764#issuecomment-390579915
cc @djmgit @ParthS007 @gabru-md @yashLadha
vaibhavsingh97
on 21 May 2018
It's been past time and i am sending PR for the same today. @vaibhavsingh97
yashLadha
on 22 May 2018
I am sending PR for the same @vaibhavsingh97 now. Cheers :+1:
yashLadha
on 22 May 2018
@yashLadha I am able to reply as today My internet connection is good. as you have seen that I was not that active from past 2 days due to connectivity issue
This is very redundant as we can see your activity online and you can still use your mobile network for the task. :+1:
yashLadha
on 22 May 2018
@yashLadha lets wait for today atleast, since @vaibhavsingh97 is so eager to send PR
djmgit
on 22 May 2018
@vaibhavsingh97 please send PR by today evenning, or else @yashLadha shall proceed with this.
djmgit
on 22 May 2018
@djmgit isn't it wrong to hold PR for such a long. I think you should make some policies for issues and PR to avoid conflicts like holding issues and deadline to merge PR. I think that would be better
yashLadha
on 22 May 2018
yes, @djmgit I implore you to see reason. There has been no activity on various differnent issue that he has picked up. It is just stalling the progress of the project. I guess @yashLadha should start working on it
gabru-md
on 22 May 2018
Yes, @djmgit, There are already 3 Redundant PRs opened for so long and there is no update on them except wrong explanations are provided on the changes requested. I request you to please see the matter like holding issues and deadline to merge PR. We can't stop the development and we should be allowed to send PRs for these issues if any.
I hope you understand what I am trying to say.
ParthS007
on 22 May 2018
@ParthS007 I know exactly what you are trying to say, let me think over this. I know holding issues for a long time is not right, slows down development pace. Let me come up with something. Will let you all know shortly
djmgit
on 22 May 2018
I will send PR before midnight. sorry for the inconvenience
vaibhavsingh97
on 22 May 2018
Related issues
ParthS007
·
6Comments
mariobehling
·
6Comments
vaibhavsingh97
·
6Comments
vaibhavsingh97
·
8Comments
ParthS007
·
6Comments
Most helpful comment
Yes, @djmgit, There are already 3 Redundant PRs opened for so long and there is no update on them except wrong explanations are provided on the changes requested. I request you to please see the matter like holding issues and deadline to merge PR. We can't stop the development and we should be allowed to send PRs for these issues if any.
I hope you understand what I am trying to say.