Badgeyay: Improve code quality (JavaScript or Python or Docker)

[niccokunzmann]

Currently, we can see issues with the code

We remove most of them! A clean code improves readability and speeds up development.

Please see the issues with the code and remove some of them. Create a separate pull-request for each file you change. In some cases, you may want to setup the project to check your changes work.

This is an issue with a lot of small tasks, so you can work in parallel or collaborate as you see fit.

[jajodiaraghav]

This is a first-timer issue. Can I still work on this?

[gabru-md]

@jajodiaraghav wait for sometime if nobody picks this up then you may do it.
Cheers

[velocitysages]

can i still work on this now?

[ba11b0y]

I will be interested to take this, if anyone has not been working already.
By the way numpy.random.random_integers() can be used instead of random.randint to solve the Standard pseudo-random generators are not suitable for security/cryptographic purposes. issue.

[gabru-md]

@ivanzaqqa and @invinciblycool
there are more than one files to be corrected.
So you can take one of the files and do the necessary changes and send in a PR.

[devesh-verma]

I am a first timer and want to contribute to foss, can I get to work on this. This is would be my first ever contribution.

[gabru-md]

Sure go ahead!

[niccokunzmann]

@devshiva619 @ivanzaqqa @invinciblycool Hi, you are welcome to contribute. If you have any questions or you like confirmation on how to go on, you can share this here and we can discuss and help. We can help eachother here or on the chat. https://gitter.im/fossasia/badgeyay

[niccokunzmann]

This is an issue with a lot of small tasks, so you can work in parallel or collaborate as you see fit.

[velocitysages]

@gabru-md i'm sorry what is PR?

[gabru-md]

PR means Pull Request @ivanzaqqa

[niccokunzmann]

When you have made changes in your repository, you can create a pull-request here: https://github.com/fossasia/badgeyay/pulls -> button "new pull request" and we can see the changes. If you are unsure, we can explain it more in detail. Please ask, then.

[rupav]

https://www.codacy.com/app/fossasia/badgeyay/file/10626798062/issues/source?bid=5114815&fileBranchId=5114815#l13

@gabru-md @jajodiaraghav can I work on this?
To replace lxml.etree.parse with its equivalent defusedxml function.

[gabru-md]

Sure go ahead

[S2606]

@rupav Yes send a PR.. 👍

[rupav]

@S2606 sent the PR :)

[toonarmycaptain]

Might be easier to break this into separate issues, but can I work on some of them?

[devesh-verma]

@toonarmycaptain even I am working on this, so just let me know which file you will be working on so that I don't work on that :smile

[devesh-verma]

@toonarmycaptain I am working on merge_badges.py

[toonarmycaptain]

I found a typo in eventyay_export_anonymizer.py.
Making some edits to the README improving grammar/readability.
Would you like me to pull for each file I edit, or in bulk?

[devesh-verma]

@toonarmycaptain rectify all the errors in one file and do a PR that's what I do.

[mohdomama]

I am a first timer and I am interested to work on this. I would like to work on the issue in generate_csv_eventyay.py if nobody is working on it. The No value for argument 'url_eventyay' in function call tocsv() can be resolved by passing system arguments in tocsv() . That is, if the generate_csv_eventyay.py is run as a standalone program, the url_eventyay, filename would have to be passed as system arguments.

[jajodiaraghav]

The two file changes after which we can close this is app/generate-badges.py and app/static/js/script.js.
Cadacy doesn't provide any details regarding how to fix the rest of files

[devesh-verma]

@jajodiaraghav so should I just work on app/generate-badges.py and app/static/js/script.js and leave rest of the files?

[jajodiaraghav]

In case you know how to fix other files, please do them as well :)

[devesh-verma]

@jajodiaraghav ok I will try my best :).
Also I wanted to ask is there anyone else also who has sent PR for app/merge_badges.py because in my PR I had changed os.system to subprocess.run and codacy was not giving any new error and now what I am seeing is that os.system has chnged to subprocess.call and codacy is giving new errors for the same.

[jajodiaraghav]

@djmgit @vaibhavsingh97 Can you please check ^

[vaibhavsingh97]

@devshiva619 Please check functionality before sending any PR 😄
Because of subprocess.run badges are not generating. PLease see #269

[lapmid]

@niccokunzmann is it still open

[devesh-verma]

@lapmid yes its open, I am currently on the issues.

[lapmid]

Could i also work on this parallelly or u are assigned to it already

On 18-Oct-2017 2:09 PM, "Devesh Verma" [e-mail] wrote:

@lapmid https://github.com/lapmid yes its open, I am currently on the
issues.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/badgeyay/issues/135#issuecomment-337505838,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AemYmEAfcI7Adi1RBWfKJ5JNn-Lxb0H8ks5stbkjgaJpZM4PdeT_
.

[devesh-verma]

@lapmid ofcourse you but there's only one file left to be corrected i.e app/static/css/jquery.minicolors.css so you can start working on this one, for rest of the files I will be sending PR.

[lapmid]

okay m going to work on this

[lapmid]

i have done a Pr for that if any other left please tell

[jajodiaraghav]

@devshiva619 @lapmid I think making change to the app/static/css/jquery.minicolors.css to fix codacy would break the minicolors functionality. The !important tag is important there. Do not remove it.

[ghost]

Hi, I am new here, could you tell me any files which nobody has dealt with, I would like to modify that.

[niccokunzmann]

Hi, I think, the issues are always updated if there is a modification made.
Which issues do you see? Are they still there?

On 11/12/2017 09:47 PM, Gaurav Chandra wrote:
>

Hi, I am new here, could you tell me any files which nobody has dealt
with, I would like to modify that.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/badgeyay/issues/135#issuecomment-343766367,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAieIHM9nZjw_TLuT4kJH8HOgrddNDL2ks5s11lYgaJpZM4PdeT_.

[mariobehling]

This is an ongoing issue and devs should be aware now. Therefore closing it. Cheers.