Badgeyay: UI bug on successful '/upload'

[gabru-md]

I'm submitting a ... (check one with "x")

• [X] bug report
• [ ] feature request
• [ ] support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/badgeyay

Current behavior:

Footer overlaps the form whenever '/upload' is successful.
Expected behavior:

The footer must not overlap with the form.
It should stay either fixed on bottom or should be placed below the form everytime.

Steps to reproduce:

Changing some CSS would definitely do.
:D

[Pk13055]

I will work on this!

[niccokunzmann]

@Pk13055 Welcome! If you have any questions, please let us know.

[Pk13055]

Sure! I will have a pull within the day!

[gabru-md]

@Pk13055 any updates ?

[S2606]

@Pk13055 This bug is not only during the upload process but when the site starts.So please take it into consideration.

[jajodiaraghav]

This is a priority design bug.

[jajodiaraghav]

@Pk13055 Are you working on this or can I work on it?

[Pk13055]

I am working on this. Was caught up with query server, will be submitting a
PR by tomorrow

On Sep 17, 2017 5:39 PM, "Raghav Jajodia" [e-mail] wrote:

@Pk13055 https://github.com/pk13055 Are you working on this or can I
work on it?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/badgeyay/issues/63#issuecomment-330039377,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM2tjCwBjmQ3g0zLtrpEU8mtPdr7c_MQks5sjQv_gaJpZM4PX-0n
.

[jishnujayakumar]

@Pk13055 Are you done with #88 or should I start fixing the bug because I am free right now?

[Pk13055]

You can go ahead.

On Sep 17, 2017 5:57 PM, "Jishnu P" [e-mail] wrote:

@Pk13055 https://github.com/pk13055 Are you done with #88
https://github.com/fossasia/badgeyay/issues/88 or should I start fixing
the bug because I am free right now.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fossasia/badgeyay/issues/63#issuecomment-330040375,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM2tjLe-UP_hs1GcZug5yomDEE0GD-V-ks5sjRA_gaJpZM4PX-0n
.

[niccokunzmann]

@jishnujayakumar If you are faster, you can do it. Best would be to work together with @Pk13055. Noone has the right to block progress. @Pk13055 can share the progress in a pull-request with [WIP] = work in progress.

[Pk13055]

Fixed (hopefully) as of #109

[nanspro]

still not fixed

[jajodiaraghav]

Let me investigate!

[Pk13055]

@nanspro You might not be on the latest push? It seems fine on my computer.

[jajodiaraghav]

@nanspro Cannot reproduce the issue.
Please rebase to latest!

[jajodiaraghav]

The issue has been fixed!
@nanspro Never forget to pull from upstream before testing :)

[nanspro]

Can you tell me what am i doing wrong @jajodiaraghav .

[jajodiaraghav]

Did you rebase you local?

1. git checkout development
2. git pull upstream development --rebase

[nanspro]

already up to date