Badgen.net: "packagephobia" badge label seems inconsistent

Created on 9 Sep 2018 · 6Comments · Source: badgen/badgen.net

It seems for the "packagephobia" badges, the label for the badge is "install size", but if there is no data for that npm module, the label instead changes to "packagephobia". I feel like the label should just always be "install size". Do you feel the same?

Example:

body-parser

csurf

wontfix

Source

dougwilson

👍2

Most helpful comment

Anyway, my question though is why would the label be "packagephobia" when it is in error but otherwise "install size"? Should it not just say "install size" for the label even in error condition?

dougwilson on 9 Sep 2018

👍2

All 6 comments

Since it appears that the badge gets generated once it's been requested, my examples above are both working now. Here is a screenshot:

screen shot 2018-09-08 at 19 29 37

dougwilson on 9 Sep 2018

👍1

Can you provide a packagephobia | unknown badge url? @dougwilson

If the request to packagephobia response 404, this badge would be packagephobia | not found, if it's timeout, the badge goes packagephobia | timeout, otherwise, it shows packagephobia | unknown.

I'm not sure what error occurs for that badge request.

amio on 9 Sep 2018

All of those badges work now. They only show unknown for a short amount of time. The OP has the second badge that was in the unknown state earlier.

dougwilson on 9 Sep 2018

Anyway, my question though is why would the label be "packagephobia" when it is in error but otherwise "install size"? Should it not just say "install size" for the label even in error condition?

dougwilson on 9 Sep 2018

👍2

By default we catch all kinds of possible exceptions in live badge functions, some might occurs before generating badge label. I would like to keep the exception handling concern as less as possible for live functions, make it simple for creating live badge, the trade-off is error message would be more general (the exception catcher didn't know the logic inside a live badge function). Fortunately, the error status shouldn't last too long, it's a temporary hint of unexpected status, so I think it's acceptable (the error info on badge are not so specific).

For your use case, you may use ?label=install%20size for consistent labels no matter what the default value is.

amio on 9 Sep 2018

👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.