Babel: [7.0] move legacy-decorators into the repo, replacing current decorators

Created on 8 Feb 2017  路  3Comments  路  Source: babel/babel

https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy

Basically since the current decorators transform throws an error, we should just move the implementation (even though it's the older stage-1 spec) into the babel repo. We'll do this in Babel 7 so it doesn't cause issues for anyone

We'll also want to change stage-1 to refer to the current transform again (reverting the previous pr) but we can do that.


  • [ ] Comment below you are going to do this (for others to know)
  • [ ] Read CONTRIBUTING.md
  • [ ] remember to run make build after a source code change or better just run make watch in another terminal window to auto run babel while you are developing
  • [ ] Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
  • [ ] Copy the contents of https://github.com/loganfsmyth/babel-plugin-transform-decorators-legacy into the transform-decorators folder under the packages/ directory. Try to keep the structure of the current repo but then replacing with src/tests/readme and merge the correct things where possible.
  • [ ] might need to change the structure of the tests to match how babel does things via fixtures, etc but we can help with this
Has PR good first issue help wanted outdated

Most helpful comment

@hzoo I'd like to work on this, if you don't mind

All 3 comments

@hzoo I'd like to work on this, if you don't mind

Sounds good! I would recommend checking out our slack community if you need help (or comment here)

Was this page helpful?
0 / 5 - 0 ratings