Babel-plugin-module-resolver: `export ... from` handling re-broken in the revert?

Created on 15 May 2017  路  8Comments  路  Source: tleunen/babel-plugin-module-resolver

128 was fixed but I believe export ... from support was broken again with the revert, from trying to follow the history bread-crumbs.

Most helpful comment

Will do, my changes for testing this are currently stashed since I'm bouncing in about 5 directions. I'll pull that up again today and gather the error. [also, I should know better than to mix issues on one ticket. New issue created]

All 8 comments

Hi @pglewis, could you please provide more details? The tests indicate otherwise, so we need more info.

Your plugin version and configuration, example code and output from the console (if there are any errors) would be a nice start. A proof of concept repo would be even more appreciated.

A vanilla "npm install babel-plugin-module-resolver -D" will currently install 2.7. I can copy the missing ExportDeclaration block into my local node_modules copy and my build _does_ work properly.

It appears 3.0 beta may handle export ... from again, but 3.0 beta errors for me.

2.6.2 has the original commit and export ... from works, however it does not work with another plugin, transform-html-import-to-string (imports our HTML/underscore templates as JS strings via normal import).

So a locally modified 2.7 is the only thing that works for me, which isn't something I can cleanly carry over to TravisCI.

What would be perfect from my side would be a NPM 2.7.1 release based off the 2.7.0 tag and including the ExportDeclaration block (and associate tests) from 627b897. It appears that would work perfectly for me and would automatically work on TravisCI.

Could you also report the error you have with 3.0 beta? Our goal is to make 3.0 stable and release it for good.

Will do, my changes for testing this are currently stashed since I'm bouncing in about 5 directions. I'll pull that up again today and gather the error. [also, I should know better than to mix issues on one ticket. New issue created]

Thanks @pglewis, you really did a great job at providing all this info! Also a lesson for me to check the history properly next time.

I'll get to fixing #175 ASAP so that you can use the beta version.

3.0 does support export ... from. My issues with 3.0 beta appear to have been version/dependency related.

Was this page helpful?
0 / 5 - 0 ratings