Babel-eslint: Error when linting valid async function with generator-star-spacing rule enabled

[doronpr]

Getting TypeError: Cannot read property 'value' of undefined error when linting valid _async function_ with generator-star-spacing rule enabled.
See minimum reproduce repository example:
https://github.com/doronpr/min-reproduce-eslint-generator-star-spacing

The problem is that babel-eslint creates AST with node.generator == true for async functions.

I believe that should be changed to false but I'm not sure what other implications it can have.

Note that this actually broke in eslint 2.11.0 in this commit (works in 2.10.*)

The following internal error is thrown:

TypeError: Cannot read property 'value' of undefined
    at getStarToken (~/src/min/node_modules/eslint/lib/rules/generator-star-spacing.js:69:25)
    at EventEmitter.checkFunction (~/src/min/node_modules/eslint/lib/rules/generator-star-spacing.js:124:29)

[doronpr]

Refs: https://github.com/eslint/eslint/issues/6274

[kaicataldo]

@doronpr Are you using the patched version of generator-star-spacing from https://github.com/babel/eslint-plugin-babel? Babel-eslint's parser produces a different AST than ESLint's default parser and so these patched rules are needed to work correctly.

[lijunle]

This workaround works for me:

parser: babel-eslint
extends: airbnb-base
rules:
  generator-star-spacing: 0

[hzoo]

Just FYI this is because there is a conflict between 2 of the eslint rules such that one of them will alwys be wrong. This will eventually be fixed with https://github.com/babel/babel-eslint/issues/350 when ESLint supports async/await in the default parser and the rule is fixed.

[tomkel]

eslint 3.6.0 supports es2017 now

[hzoo]

The logic was added to support async/await for different rules with eslint before it was supported - https://github.com/babel/babel-eslint/issues/361