Azure-sdk-for-python: aka.ms/pysdkmodels link broken/TODO

[akx]

Hi!

The link https://aka.ms/pysdkmodels referred to in the https://github.com/Azure/azure-sdk-for-python/blob/4a76ec8443613f0ed3add530f9896d77eabd899d/azure-mgmt-compute/azure/mgmt/compute/models.py#L13-L14 deprecation warning is broken.

Or, I mean, it points to https://github.com/Azure/azure-sdk-for-python/wiki/Direct-access-to-%22models%22-is-deprecated which is rather barren.

[lmazuel]

Hi @akx
Ok, that's on me :/. I postponed, and postponed and then forgot.... Put it back on my TODO. Sorry about that.

[boumenot]

Friendly bump. I was excited to read how to fix this.

I just followed the link today, and found that it was a TODO.

[lmazuel]

@boumenot @akx I wrote the article, please let me know what you think before I close the issue :)
Thank you!

[akx]

Thank you :)

Wouldn't Solution 3 be to import the model from the package for the particular API version, for e.g. code completion or typing?

[lmazuel]

@akx , but this solution requires that you know the API version you are targeting. We try to make this as hidden as possible, like an implementation detail. Because on public azure you shouldn't care, and on Azure Stack / Government you should use a "profile" (which is still hiding the API version).

So it will technically work, but I'm not a huge fan to document it as a solution. Or at least I need a lot of warning "If you understand why you're doing that"

[akx]

Check. Well, I'll pinky swear I'll keep those imports only within if typing.TYPE_CHECKING: blocks. Is that fine? :D

[lmazuel]

Sounds good to me :). I will add an advanced version with a lot of warnings still.
Glad hearing you talk about typing by the way ;)