Azure-sdk-for-net: [BUG] EventDataBatch disables diagnostic properties and plugins

[gyuwon]

EventDataBatch creates AMQP messages before the event sending process so when using it results the loss of Diagnostic-Id, Correlation-Context and any other properties set through plugins without any feedback.

I understand why EventDataBatch generates AMQP message when TryAdd is called but it would be better to give some warning at such situation.

[AlexGhiondea]

@gyuwon can you share more information about this?
What library are you using?
What code are you writing for this?

[jsquire]

The mention of plugins identifies this as the track one library. I'd like to ask @serkantkaraca, @sjkwak, or @JamesBirdsall to offer their thoughts.

[gyuwon]

The following code not only calculates the size of the event data but also generates AMQP message.

https://github.com/Azure/azure-sdk-for-net/blob/1264615ef858e1c368e1ba2b89771fdb1be69428/sdk/eventhub/Microsoft.Azure.EventHubs/src/EventDataBatch.cs#L84-L86

And BeforeEventSend method of EventHubsPlugin allows us to modify EventData.

https://github.com/Azure/azure-sdk-for-net/blob/1264615ef858e1c368e1ba2b89771fdb1be69428/sdk/eventhub/Microsoft.Azure.EventHubs/src/Core/EventHubsPlugin.cs#L29

But in the case of batch sending scenario, AMQP message was already created before run plugins so modifications from plugins are just ignored.

[serkantkaraca]

Thanks for reporting this. Let me check the code and provide you my findings.

[serkantkaraca]

We are going to have a fix in the next release.

[msftbot[bot]]

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

[serkantkaraca]

Keeping the issue active. This will be fixed as part of 4.3 release. Thx.

[msftbot[bot]]

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

[jsquire]

There should be no immediate action needed, per Serkant's comment. Trimming up some tags to discourage the bot from interfering with the tracking and release process.

[serkantkaraca]

Fix is merged. This will be available by 4.3.0 release.