Azure-sdk-for-js: Onboard Schema Registry service

Created on 15 Jul 2020  Â·  14Comments  Â·  Source: Azure/azure-sdk-for-js

Schema Registry is a new service that is currently in private preview.
This issue is to track work to onboard the SDK for this service.
This work is planned for the August milestone and does not involve shipping the package which will be done in the September milestone.

  • decide package name
  • auto generate the package using the latest v6 code generator on the swagger
  • set up CI

For reference, please see the Java SDK for Schema Registry

Client Schema Registry

All 14 comments

Please wait until the swagger makes it to the https://github.com/Azure/azure-rest-api-specs/ repo. I'll post an update here when it does

decide package name

@ramya-rao-a Is there a formal process for approving a name? Should we pick an interim name pending a review? @azure/schema-registry?

Please wait until the swagger makes it to the https://github.com/Azure/azure-rest-api-specs/ repo

I checked with Arthur about this and he will be looking at it soon.

@azure/schema-registry sounds perfect. @bterlson, do we have your blessing?

The current swagger caused a problem for the generator, sent https://github.com/Azure/autorest.typescript/pull/705 to fix it

+1 for @azure/schema-registry.

https://github.com/Azure/azure-rest-api-specs/pull/10220 is the link to the PR adding the swagger to the rest-api-specs repo. Please retry the generation and see if there are any other issues now that the upstream bug with the code generator is fixed

Generation succeeds on https://github.com/Azure/azure-rest-api-specs/commit/1296087cd0050d62dce3292b1d0d2eab2e7729b9 (latest commit in PR at this time). :)

If you have not started yet, please do use the template folder in the repo. We'd like to hear what works and what doesn't when using the template as a reference to add a new package to the repo

Ok. I will use the template folder 📂

Get Outlook for iOShttps://aka.ms/o0ukef


From: Ramya Rao notifications@github.com
Sent: Tuesday, July 28, 2020 7:33:26 PM
To: Azure/azure-sdk-for-js azure-sdk-for-js@noreply.github.com
Cc: Sarangan Rajamanickam sarajama@microsoft.com; Assign assign@noreply.github.com
Subject: Re: [Azure/azure-sdk-for-js] Onboard Schema Registry service (#10076)

If you have not started yet, please do use the template folder in the repo. We'd like to hear what works and what doesn't when using the template as a reference to add a new package to the repo

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-sdk-for-js%2Fissues%2F10076%23issuecomment-665395121&data=02%7C01%7Csarajama%40microsoft.com%7C4920ca466bc04b7fac4f08d83367c59e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637315868072642566&sdata=rvP9iN4QlrCeEplnaEUBO9KBCIMZ05OKXdDe2SpidRc%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAETCWC33H4KOWV5PC4KWELR56C7NANCNFSM4O2HFRMA&data=02%7C01%7Csarajama%40microsoft.com%7C4920ca466bc04b7fac4f08d83367c59e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637315868072642566&sdata=%2Btmx%2BGnQMSt517XbtW%2BtBE27BJ8KBHBfcNPZuxsBbFM%3D&reserved=0.

@sarangan12 @ramya-rao-a This issue got assigned to me and I have started on it (a little). So far I just copied an autorest config file from another library and pointed it at various in-progress versions of the swagger. This led to https://github.com/Azure/autorest.typescript/pull/705. I haven't started on setting up the build or anything, so nothing much to redo starting from the template, which I can definitely do. I do want to make sure I'm not duplicating work by continuing on this issue, though...

There was a slight confusion here :)

The issue was initially assigned to @sarangan12, so when he got notified of my comment above, he jumped to reply without seeing the previous context

No harm done, this is all you @nguerrera, go on full steam ahead!

@ramya-rao-a I put up a draft PR: #10336. Feedback welcome. It's still completely untested and likely missing things to get it to work end-to-end. My next step will be to try to use it, adding appropriate tests and samples.

10336 is out of draft. I am going to look at testing as part of building the outer convenience layer. #10336 doesn't export anything so there's nothing to test as part of that PR.

Was this page helpful?
0 / 5 - 0 ratings