Update samples for each package that we are releasing. Follow the guidelines about
@ramya-rao-a
Below are the applicable packages in the order of priority
All packages have a samples directory with samples
All packages except Keyvault have a readme
@willmtemple Please sync up with @kaerm on what kind of advanced scenarios are we looking for and we can take a call on what needs to be done there
@kaerm The samples themselves are up to date. Please log new issue for any specific missing samples. Updating this issue title to reflect changes to only the readme files for samples.
Closing #4940 to prefer this issue.
I'll fix up the /samples/README.md files in addition to the /samples/typescript/README.md and /samples/javascript/README.md files for any errors as I'm going through.
@ramya-rao-a @kaerm FYI this is blocked on figuring out why the samples don't currently render in docs.microsoft.com. Since #6208 was merged I expected to see the TS/JS samples for file-share online but they're still not up.
This is not working because on our side we do not have the webhook configured. @scbedd - can you help enabling it for all the remaining repos?
@kaerm I'll sync with scotk today and get it done.
@kaerm @scbedd Any update on this? Not seeing the existing ones in docs.microsoft.com/samples if I browse to TypeScript/JavaScript and Azure Storage. Is it a matter of merging a change to those files and kicking off a web hook for the docs pipeline to start the ingestion process? #6496 should be merged soon, and I think it's all formatted and annotated correctly, but without being able to see the rendered pages it's impossible to know for sure.
@weshaggard was taking care of adding the webhook (I do not have admin perms on the repo). It was lower on his priority list, so it's a possibility it's not already done. Wes?
The webhooks are setup and enabled now.
Awesome, thanks! Do we have an idea of how long it takes to go from a commit being merged to master to seeing the changes live?
We're seeing the samples for storage live now. https://docs.microsoft.com/en-us/samples/browse/?products=azure-storage&languages=typescript
Thanks everyone!
@kaerm when #6997 and #6998 are merged this will be closed.