Azure-rest-api-specs: [HDInsight] `KafkaRestProperties` should not require `groupName` given `groupId` has been specified

Created on 2 Sep 2020  路  12Comments  路  Source: Azure/azure-rest-api-specs

The ClientGroupInfo property already accept a groupId in request body, based on which service should be able to deduce the groupName. This issue suggest to remove the groupName from the model as an input property.

HDInsight Service Attention question

All 12 comments

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @aim-for-better, @idear1203, @deshriva.

Hi @magodo , This is by design, This property not only as input but also as output. Please see here, This property will return to customer when they call Get cluster API.

Hi @magodo , This is by design, This property not only as input but also as output. Please see here, This property will return to customer when they call Get cluster API.

Returning group name is more readable for customer.

Could you please share more about this issue? For example, what's the impact on you?

As the API consumer, it is more handy to provide the least amout of input in request. In this case, groupName can be deduced from groupId, which seems redundent to ask users to also specify. Otherwise, making groupName as output only (readOnly) might be a better choice here.

Specifically, I'm working on this feature in Terraform azurerm provider. Check out this comment: https://github.com/terraform-providers/terraform-provider-azurerm/pull/8064#discussion_r480079072

@magodo : Thanks for the feedback. We have opened a work item and plan to address it in a future release.

@magodo : Can we close this request, we have a work item and this change will be rolled out with a new API version.

@deshriva Thank you for the update, can we wait until the Swagger PR for that new API version is merged?

Thanks for the feedback. We have opened a work item and plan to address it in a future release.

on going

on going

on going

on going

Was this page helpful?
0 / 5 - 0 ratings