Azure-rest-api-specs: OperationId in GraphRbac 1.6 should not contains the word Operation

[lmazuel]

For instance "operationId": "ApplicationOperations_Create"
Should be "operationId": "Application_Create"

Since the Operations string is already added, this create weird class name with Autorest

Not that the operations id were fine in GraphRbac 1.42. Moreover, no other Swagger files use Operations in their operation id.

[devigned]

yeah... that's a lot of operations... :[

[devigned]

@shuagarw can you provide some feedback on this?

[amarzavery]

@devigned
There is a collision in the spec with Application being an operation as well as a model definition. To resolve it he added the keyword operation in operationID.

It looks perfectly fine in the node.js codegen https://github.com/Azure/azure-sdk-for-node/tree/master/lib/services/graphManagement/lib/operations

This must be a bug in the python codenamer.

[devigned]

@lmazuel and @amarzavery you guys should probably get on the same page here.

[devigned]

In fact, if someone could say exactly what the codenamer should do, I think all the languages could then implement it properly. I'm guessing this is an edge area that is not handled by all.

[lmazuel]

Same classes in different language:
Java:
https://github.com/Azure/azure-sdk-for-java/blob/autorest/azure-mgmt-network/src/main/java/com/microsoft/azure/management/network/ApplicationGatewaysOperations.java
Node:
https://github.com/Azure/azure-sdk-for-node/blob/master/lib/services/networkManagement2/lib/operations/applicationGateways.js
Python:
https://github.com/Azure/azure-sdk-for-python/blob/master/azure-mgmt-network/azure/mgmt/network/operations/application_gateways_operations.py
Ruby:
https://github.com/Azure/azure-sdk-for-ruby/blob/master/resource_management/azure_mgmt_network/lib/azure_mgmt_network/application_gateways.rb
C#:
https://github.com/Azure/azure-sdk-for-net/blob/tm-autorest/src/ResourceManagement/Network/Microsoft.Azure.Management.Network/Generated/ApplicationGatewaysOperations.cs

Java, C# and Python appends Operations.
Ruby and Node do not.

[lmazuel]

@devigned @amarzavery what do you think? It's clearly not just a Python problem. Any change will be a major breaking changes.
I guess we could cut the extra "Operation" suffix if it's necessary for Ruby and Node to have one in Swagger to disambiguate some situations. I'm not a huge fan, I would have preferred that Ruby/Node append the Operations suffix too, like the three other clients. This should be enough to disambiguate in Node.

[amarzavery]

The ambiguity is in the modeler and not in the Language codenamer.

[lmazuel]

Sorry, I didn't understood that before.
But it does not change that we have to decide something about the Operations suffix right?

[devigned]

@lmazuel and @amarzavery where does this stand?

[lmazuel]

After the meeting today and last minute discussion with @devigned and @markcowl we should keep everything the most simple possible with a simple rule:

• Swagger files should not use Operations in their operation ids
• Every generator should append Operations. Always.

This keeps the guidance for a language generator really simple that an Operations class must ends with Operations. No language specific rule, no test like if ends with Operations, do not append which will reach a limit one day for sure.
We should _not_ test the presence of Operations in the operation id, the SDK of all languages will be weird enough to force the service team to remove it anyway. This works only if we all follow the same rule.

[lmazuel]

The RestApi problem is fixed, the Swagger file does not contain "operation" anymore