Azure-docs: Option 1 and 2 are identical

Created on 18 Jun 2019  Â·  10Comments  Â·  Source: MicrosoftDocs/azure-docs

Both options listed here use the exact same commands to add a completely new key to the key vault. What's the other option supposed to be?


Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

cxp doc-bug securitsubsvc sql-databassvc triaged

All 10 comments

@sean-nixon Thank you for bringing this to our attention. I will have a correction made to the documentation.

@aliceku The Manual key rotation (link) and the Option 2: Manual rotation (link) are exactly the same?! @CarlRabeler for awareness.

@VanMSFT for awareness

There is only the option of manual key rotation, we had to disable automatic key rotation, because that was breaking the geo-dr scenario. It's just a matter of changing the article to make clear that there is only one option now: manual rotation.

I don't know why the manual section is duplicated though, the Option #2 can be removed.

Removing section.

Someone beat me to it. @sean-nixon An update will be published within the next 24 hours.

Looking through the history of this document, it used to be ## Option 1: Auto rotation and ## Option 2: Manual rotation but with the recent migration to az.sql, the auto functionality does not exist and manual was being used as a placeholder until the functionality became available. Subsequently, a PR was issued to change Option 2 via the following commit: https://github.com/MicrosoftDocs/azure-docs/commit/97626512c0b15f062c828a11c0b6c22b06cc3335#diff-225fee344f4dee51635ad67c1d7f807a

But I am not seeing the PR where Option 2 has been removed. That needs to be approved and merged.

We removed option one, the auto-rotation, because it was breaking the geo-dr scenario. We are blocking auto-key rotation now. I had removed that section, but didn't realize that option 2 was duplicated. I just removed the duplicated section.

Thanks @aliceku !
@sean-nixon We will now proceed to close this thread as an update should be published within 24hrs. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

JamesDLD picture JamesDLD  Â·  3Comments

bityob picture bityob  Â·  3Comments

mrdfuse picture mrdfuse  Â·  3Comments

AronT-TLV picture AronT-TLV  Â·  3Comments

jamesgallagher-ie picture jamesgallagher-ie  Â·  3Comments