Azure-docs: The code displayed on this page does not retry as indicated

Created on 4 Feb 2019  Â·  16Comments  Â·  Source: MicrosoftDocs/azure-docs

The code showed in item "4" on the "Open and edit the solution" section does not work as indicated. In case a 429 is returned by keyVault, the code won't actually retry as suggested. That's because the try/catch block is outside of the loop. In addition, the variable "waitTime" is not used anywhere in the code.


Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Pri1 assigned-to-author awaiting-product-team-response doc-enhancement in-progress key-vaulsvc triaged

Most helpful comment

Guys, I also do not understand how this code works. Unused functions, bogus retry variables.
Better remove than keep and confuse.

All 16 comments

@grlima Thanks for the feedback! We are currently investigating and will update you shortly.

@grlima
Thanks for pointing this out. As per our investigation we are also able to get the same result.

@prashanthyv
Could the code sample as mentioned by the user be re-checked as we are also not able to get it working ?

Hi @grlima - Please look out for the next PR.
Thanks

Hi @prashanthyv @YutongTie-MSFT @grlima
Has this problem been fixed?

Yes it has

@prashanthyv so the above code sample now works as expected? I just tried it and it appears to get the secret twice which doesn't seem right. It gets it once from the original getAsync then gets it again in the do while loop.

@developercreativepos - Are you looking at this page - https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-throttling ?

Thanks. Will fix that

Awesome, thank you. Do you have an ETA for when it will be updated?

Is there a way to subscribe to this issue, either on Microsoft or GitHub?

@JohnBoncek - The fix should be available by tomorrow

Hi guys, well the variables: retry and retries are not being used in this tutorial (https://docs.microsoft.com/en-us/azure/key-vault/tutorial-net-create-vault-azure-web-app), there are no retries here.

@barclayn do you know the status on this tutorial?

Guys, I also do not understand how this code works. Unused functions, bogus retry variables.
Better remove than keep and confuse.

Code is updated with retries. #please-close

Was this page helpful?
0 / 5 - 0 ratings

Related issues

spottedmahn picture spottedmahn  Â·  3Comments

JeffLoo-ong picture JeffLoo-ong  Â·  3Comments

varma31 picture varma31  Â·  3Comments

jebeld17 picture jebeld17  Â·  3Comments

mrdfuse picture mrdfuse  Â·  3Comments