Azure-docs: Is it CRLF or just LF?

[dlstucki]

The text states:
is the SHA-256 hash computed over the resource URI (scope as described in the previous section) and the string representation of the token expiry instant, separated by CRLF
Then the pseudo-code uses simply 'n':
SHA-256('https://<yournamespace>.servicebus.windows.net/'+'\n'+ 1438205742)

Can you make these consistent and correct?

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: 13478d1d-11eb-930a-02c4-559a1ef89fa6
• Version Independent ID: be36cdf9-1e5e-c47f-e699-652dc42ee2b9
• Content: Azure Service Bus access control with Shared Access Signatures
• Content Source: articles/service-bus-messaging/service-bus-sas.md
• Service: service-bus-messaging
• GitHub Login: @sethmanheim
• Microsoft Alias: sethm

[femsulu]

@dlstucki Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

[rwatjen]

It is just \n according to https://github.com/Azure/azure-sdk-for-net/blob/4bab05144ce647cc9e704d46d3763de5f9681ee0/sdk/servicebus/Microsoft.Azure.ServiceBus/src/Primitives/SharedAccessSignatureTokenProvider.cs#L143.

The SHA-256 pseudo-code is misleading. The signing is done with HMACSHA256 using the SAS policy's primary or seconday keys as input key. (https://github.com/Azure/azure-sdk-for-net/blob/4bab05144ce647cc9e704d46d3763de5f9681ee0/sdk/servicebus/Microsoft.Azure.ServiceBus/src/Primitives/SharedAccessSignatureTokenProvider.cs#L167)

[dlstucki]

It wasn't hard for me to figure out which was correct. The point of this issue is to have the documentation fixed to be consistent and point users at the right format. Read the initial description. (I'll update title to clarify).

[rwatjen]

I just wanted to point out the source and also that the pseudo-code is at best misleading (it doesn't mention they key at all), and also I wanted to get some attention on this issue, which has been open for 11 months now.

[canuzun]

n is a bit unclear. However, "SHA-256('https://.servicebus.windows.net/'+'n'+ 1438205742)" is not misleading, it is dead wrong.

Also a real example should be added, n and HMACSHA256 and url encoding stuff may make much sense with an example and save a lot of time for us.