Azerothcore-wotlk: Server became unstable

[Bogir]

Server became unstable after applying updates #2618, #2622, #2639, #2650
It crashes from time to time without a reason.
Server can work from 1-2 minutes to 2-3 hours

BRANCH(ES):

master

OPERATING SYSTEM:

Windows 7

[diluh]

I confirm - server gets stuck and doesn't fail after

See in the video
https://streamable.com/qm0f3

[BarbzYHOOL]

does it happen even if you launch the worldserver and do nothing? (no login, no playing)

If so, can you reproduce it at the same time or not?

[Bogir]

does it happen even if you launch the worldserver and do nothing? (no login, no playing)

If so, can you reproduce it at the same time or not?

For me - ti is so. No matter if there is players or not. Today server crashed in 7 hours

[pklloveyou]

I used #2618, #2622, and did not crash

[BarbzYHOOL]

does it happen even if you launch the worldserver and do nothing? (no login, no playing)
If so, can you reproduce it at the same time or not?

For me - ti is so. No matter if there is players or not. Today server crashed in 7 hours

this shows 1 player online, also I have never seen this "X sessions" thing lol

[diluh]

I removed the pr #2622 #2639 and apparently is normal

[Bogir]

I have never seen this

It is custom line
sLog->outBasic( "Online %u players with %u sessions.", sWorld->GetPlayerCount(), (uint32)(sWorld->GetActiveSessionCount()));

Also, if you noticed, I removed

if it no more 10 ms:
if (avgDiffTracker.getAverage() > 10)
sLog->outBasic("Average update time diff: %u. Players online: %u.", avgDiffTracker.getAverage(), (uint32)GetActiveSessionCount());

[BarbzYHOOL]

https://github.com/azerothcore/azerothcore-wotlk/pull/2622 is huge, seems more likely to be related

can you retry without this one only?

PS: what are players sessions @Bogir ?

[Bogir]

It is shows how many players loged in and staying on character selecting screen (don't know how to correctly describe it in English)

[diluh]

@BarbzYHOOL @Kaev I think it's related to this PR that you mentioned.

[Bogir]

@BarbzYHOOL In any case, at this time we have only 1confirmation of server crash. It is very little.
So I start to think that reason is in custom modules, not in the our core

[BarbzYHOOL]

• Just revert that big PR and retest
• List your modules, please (but you are not working together on the same server Diluh and Bogir?)

---

Offtopic:

It is shows how many players loged in and staying on character selecting screen (don't know how to correctly describe it in English)

ok but how can 1 player be connected TWICE on the character selection screen ?? 2 sessions

[Bogir]

No, I have mine test server))

Offtopic: 2 players connected to Login server (Auth server: 2 sessions) and 1 of them is staying on character selection screen (AFK-character disconnected from Game server or player still not decide which character hi wants to play)

[BarbzYHOOL]

list your modules guys!

offtopic: ah ok nice Bogir, I would make the clear distinction personally (authserver/worldserver) but it's cool

[Bogir]

mod-autobalance-master
mod-solo-lfg-master
They are combined together to 1 module, and I think the reason is somewhere here. Perhaps I have some conflict with #2622

[Bogir]

@BarbzYHOOL Could you add label "Need confirm" for this issue? If nobody confirm it I'll close it soon

[diluh]

I don't have any of these modules mentioned, and I confirm this error, don't do the same thing they did with the Pets error, all saying that there was no error and in the end @vhiperdev showed the faulty commit and it was corrected.

[Bogir]

And why the others not confirm this crash? Maybe they have no errors/conflicts and we must test it on a clear cloned core? Simply run clear server and wait =)

[Bogir]

So, now I cloned clear core lastest revision, compilled, started server and went to sleep =)
Tomorrow will se result

[solidmaxtor]

i am use commit b1bcd21 (30/01/2020) full modules.
No problems for me, check lasts changes 1-9 feb

[Viste]

[BarbzYHOOL]

I don't have any of these modules mentioned, and I confirm this error, don't do the same thing they did with the Pets error, all saying that there was no error and in the end @vhiperdev showed the faulty commit and it was corrected.

instead of complaining, you should help finding the bug like vhiper did, it's your role here, not just say "bug plz help slaves"

note: that I talked with vhiper many times during that bug

[Bogir]

I don't have any of these modules mentioned, and I confirm this error,

I had conflict with my customization and pr #2622 and fixed it.
To find where is your problem you can clone clear core, add 1-2 of your modules or customizations and test how server will be work.