Azerothcore-wotlk: Buffs stack

[Zausender]

Stacking buffs

SMALL DESCRIPTION:

EXPECTED BLIZZLIKE BEHAVIOUR:

This buff does not stack with the paladin buffs [Blessing of Kings] or [Greater Blessing of Kings].

CURRENT BEHAVIOUR:

Using paladin buff Blessing of the Kings with Drums of forgotten kings apply both buffs. on player.

STEPS TO REPRODUCE THE PROBLEM:

1. Create paladin, buff self with Kings
2. .add item 49633 ( Drums of F.Kings) and use it
3. Result, you have Kings 10% buff and 8% Drums buff

EXTRA NOTES:

BRANCH(ES):

master

AC HASH/COMMIT:

OPERATING SYSTEM:

MODULES:

OTHER CUSTOMIZATIONS:

[Ashland]

Yes this buffs stack for me too

[BarbzYHOOL]

hmm isn't this behaviour defined in the dbc normally ? or maybe it's a special spell

[GMKyle]

"Visual" issue (i don't know how this spells behave on retail visually speaking), same as https://github.com/azerothcore/azerothcore-wotlk/issues/2473

[Zausender]

"Visual" issue (i don't know how this spells behave on retail visually speaking), same as #2473

How its visual, when stats get increased from both buffs? (You should test first). Also, I did tc setup, their core doesn't have this issue.

[GMKyle]

I tested and i can't reproduce, players only benefits from Blessing of Kings if the 2 buffs are present (10 % better than 8%). Perhaps someone else should test this.

[ghost]

I also cannot reproduce this issue. If both buffs are present only the greater one is applied to the stats (10%).

[Zausender]

To be honest, you tested it just with Greater Blessing of Kings, in combination with drums. That's incorrect, and there stats isn't increased when both are applied.
Like i said, test with Blessing of Kings (Not Greater) and you'll see problem.
Will show now with images behaviour:

Drums in combination of Blessing of Forgotten Kings:

1. Without buffs
   

2. With Drums applied (Stats increased)
   

3. With Drums and Kings (Paladin buff) - Stats increased from both.
   

Now images when Greater Blessing of Kings applied with Drums

1. Greater Blessing of Kings applied (Stats increased)
   

2. Greater Blessing of Kings + Drums (Stats not increased for both, as you can see we have same stats now like on first image, which mean it's correct only with Greater Blessing of Kings)
   

I'm on the https://github.com/azerothcore/azerothcore-wotlk/commit/d769d0e62c5ae7b29f28ad55138120e360f60019 version, and this problem exist there.
Just downloaded latest ac, clean, without any modules or edits, problem is same.

[ghost]

I tested it with "Blessing of Kings", not with "Greater Blessing of Kings".

[Zausender]

I tested it with "Blessing of Kings", not with "Greater Blessing of Kings".

Stoabrogga commented 4 hours ago
I also cannot reproduce this issue. If both buffs are present only the greater one is applied to the stats (10%).

[ghost]

Yes, 10% is greater than 8%, that's what I meant.

[Zausender]

Yes, 10% is greater than 8%, that's what I meant.

You should have written it a little more precisely. Because we already have that name clearly declared Greater Blessing of Kings -> Blessing of Kings (Not same) / Both of them give benefit 10% impStats, so it's not 10% is greater than 8%. But nevermind, i understand what you mean.
So, let's leave this issue opened until someone else confirm this as the valid issue. And as the comparison on the trinity core, they doesn't have this problem (Actually they fixed it, any of the Greater buffs from Paladin replace drums, that's also blizzlike behaviour) and that is how the spell should work here too.

[ghost]

If I meant "Greater Blessing of Kings" I would have written so. And 10% from the Blessing of Kings is greater than 8% from the Drums, and in my tests only the 10% were applied to the stats.

[Zausender]

Just checked a bit more, and something is wrong here with core and DB spell_group / stack_rules

Also, @Stoabrogga (taggin' you cuz you commented)
The steps to reproduce it:

1. First, do Drums buff
2. Check your character stats (They're increased)
3. Now apply paladin kings (Stats increased more)

I notice, cuz if you doing it with Paladin kings, than Drums the stats won't increase.

Important: First do Drums buff, than Kings and you'll see what's issue :)

[pangolp]

Perform the following tests.

First:

• Use 10-minute kings and then the drums.
  The results were that when I applied the kings, my statistics increased, but then when I used the drums they didn't change.

Next:

• Use the drums first and then the kings.
  The result was that the drums increased my statistics by 8%, but when I used the kings, they were replaced by the 10% buffo, obtaining the same result.

In conclusion
As much as you have both buffos, your stats are always 10%.
We should only prevent the use of drums, in case there are kings I think, if I'm not wrong, the issue is so.

[ghost]

@Zausender

The steps to reproduce it:

1. First, do Drums buff

2. Check your character stats (They're increased)

3. Now apply paladin kings (Stats increased more)

Of course the stats increase if you apply the Blessing of Kings after the Drums: Blessing of Kings has a 10% buff which overwrites the 8% buff of the Drums. But they don't stack, you are not getting 18% increased stats or something like that.

[pangolp]

No, neither way you get 18%. The maximum number is always 10% regardless of the way they are applied. You should only perhaps prevent one from being used if the other is present. I think that's officially the way it is. But I could be wrong.

[ghost]

Yeah, that's what @GMKyle meant with "visual" issue above, you have both icons in the buff list. But technically it's correct, because only the biggest buff is applied to the stats.

[pangolp]

I mean, wouldn't it be a problem to have both of them in the picture? It can be confusing for people. Anyway, if you check the statistics, you'll notice that you don't get any benefit.

[Zausender]

@Zausender

The steps to reproduce it:

1. First, do Drums buff

1. Check your character stats (They're increased)

2. Now apply paladin kings (Stats increased more)

Of course the stats increase if you apply the Blessing of Kings after the Drums: Blessing of Kings has a 10% buff which overwrites the 8% buff of the Drums. But they don't stack, you are not getting 18% increased stats or something like that.

To be clear about this, it's not visual bug, it's mistake somewhere in the core or the db cuz when you check character current auras, the character has both auras which means one aura isn't removed. Also, you can check for example druid Marks of Wild with Drums of the Wild which work same like that Kings buff. Even both of them are created by LW (We have correct way with the Drums of Wild, druid buff replacing Drums always and one aura stick on character).
Same, how that spell work, this Kings should work also. I tried to check core in the spells, but can't find nothing related to this calculations, only one which i find is the Hack fix for the GBOS (Greater blessing of Sanctuary).

[ghost]

I think it is wrong to remove the aura with the smaller buff, because after all it's a valid aura. If the bigger buff aura is removed the lower one still exists and then applies it's increase to the stats. Sorry, but I don't see any error here, everything's working as intended.

[ghost]

There's also a comment on wowhead:
https://www.wowhead.com/item=49633/drums-of-forgotten-kings#comments:id=908904:reply=140475
It does not stack. You can have both buffs on you, but you won't be getting 18% to all stats, only 10%, from the stronger spell.

[NixAJ]

You may refer to

https://wowwiki.fandom.com/wiki/Buff?oldid=2403106
Which document generally speaking which buffs are overriden in what order.

You may also refer to https://wow.gamepedia.com/Drums_of_Forgotten_Kings specifically to see that Drums of Forgotten Kings DO NOT stack with Blessing of kings

[Zausender]

There's also a comment on wowhead:
https://www.wowhead.com/item=49633/drums-of-forgotten-kings#comments:id=908904:reply=140475
It does not stack. You can have both buffs on you, but you won't be getting 18% to all stats, only 10%, from the stronger spell.

Is this enough? :)

Also on this core:

1. Casting Paladin Kings and Drums of Kings ( We have 2 icons on player / 2 auras)
2. Casting Druid Wild and Drums of Wild (We have just strongest icon buff / and 1 aura)

Explain it?

[ghost]

They already do not stack, so nothing to fix here in my opinion. And as the wowhead comment from 2010-01-01 (patch 3.3.0) states you can have both buffs on a player character, but only the stronger one counts. Sorry, but I said everything I have to, I'm out of this discussion.

[Zausender]

They already do not stack, so nothing to fix here in my opinion. And as the wowhead comment from 2010-01-01 (patch 3.3.0) states you can have both buffs on a player character, but only the stronger one counts. Sorry, but I said everything I have to, I'm out of this discussion.

Go and play retail, try buff up both of them, maybe you understand, and accept it. Even stats are not stacked, the only one icon (from higher spell eff) can be there (writing and trying to provide infos like its visual bug only, its unprofessional and in one hand sad). I didnt except a lot from you, to be honest, related to your way of commenting and providing some comments of course you re out of discussion, because you cant provide better info, except random person comment. Everyone can put comment there, so it doesnt help a lot and doesn't give any proofs at all.
I would like to hear the explanation about same item spell "Drums of the wild" which work in same way like "Drums of forgotten kings" why that Drums of the wild doesnt provide buff (icon) near Druids buff Mark of The Wild (Why we dont have icons from both buffs? And why higher buff override lower, in this situation Druid buffs stay at buffed character, and the buff from drums of wild is removed. Isn't that interesting, no?
I think it's very simple to understand this, but you have your own way. So keep it, I'll keep mine.

P.S I found what causing it.

[BarbzYHOOL]

I agree with stoabrogga and I trust GmKyle, Stevej and Stoabrogga tests as they contributed many times in the past.

[Nefertumm]

For whose want to avoid having both icons instead of 1, just add a condition on spell_linked_spell.