Azerothcore-wotlk: Command: Learning profession recipes

[Zausender]

Command learn all recipes

SMALL DESCRIPTION:

Doesn't work correctly

EXPECTED BLIZZLIKE BEHAVIOUR:

They shouldn't give bug with profesions

CURRENT BEHAVIOUR:

Learn Two profession at trainer (I'll use Alchemy and Jewelcrafting). Than use command
.learn all recipes Alchemy
.learn all recipes Jewelcrafting

Once you learned, you can't unlearn profession.
To be precise, they will be removed under character skill tab when you click unlearn profession, but when you re-log they are still there. Actually they are not unlearned.

Also, when you do all of these steps, you can get more than 2 professions, just speak with trainer, and learn how much you want.
Which is totally wrong, and everything is caused with command .learn all recipes

STEPS TO REPRODUCE THE PROBLEM:

1. Everything explained in CURRENT BEHAVIOUR
2. 
   
   
   3.
   

EXTRA NOTES:

BRANCH(ES):

master

AC HASH/COMMIT:

https://github.com/azerothcore/azerothcore-wotlk/commit/b3876461e8e4333c5887d761288da4beea223b06

OPERATING SYSTEM:

Debian 10

MODULES:

No

OTHER CUSTOMIZATIONS:

No

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[vhiperdev]

I confirm

[Zausender]

_Thank you @vhiperdev for confirmation.
This is critical and gamebreaking issue caused by core command. There is also module in azerothcore modules (Profession NPC). All professions works in this way, handling and learning all recipes to player. In this case module is also useless same as this command. Will be great if someone of devs here take a look on this and try to fix it. Otherwise, turn off the module related to this and disable this command from the core, as it is useless too, leaving the player or anyone else unable afterwards to unlearn all recipes._

[wizzymore]

Well, i don't think this is a critical or gamebreaking issue as it only happens for gm's not for every player making the game unplayable

[Zausender]

Well, i don't think this is a critical or gamebreaking issue as it only happens for gm's not for every player making the game unplayable

How? You have module provided by AzerothCore, where all professions are instantly learned. And also recipes, it's everything handled with command .learn all recipes Alchemy.
I'm sure a lot people using it on their server, but they didn't recognize that players can learn all professions in that way. Especially for custom servers.

And Ofc, it's gamebreaking issue. Every module, script for Professions working with this command.
So, delete module from list, or disable this command cuz it doesn't work correctly.

As better explaination :

https://github.com/azerothcore/mod-npc-free-professions/blob/97c1154b023b011e226838f564008307bd2afdb6/src/ProfessionNPC.cpp#L119

[IntelligentQuantum]

@Zausender it's not best solution, but it's better than nothing :smile:

https://gist.github.com/IntelligentQuantum/d85aa0f57c6d2f3202e1eb8dee7ac5ee

[V3nomAnc3r]

@IntelligentQuantum Tnx!!!

Can you fix this module please https://github.com/azerothcore/mod-npc-free-professions

[IntelligentQuantum]

@V3nomAnc3r https://github.com/azerothcore/mod-npc-free-professions/issues/new

[furywow]

Any news 😢