Azerothcore-wotlk: [Feature Request] Cross-Faction Dungeon Finder [$30]

[andoys]

Feature Request: Cross-Faction Dungeon Finder
Must work with CFBG Module Enabled

• Can be Module
• Core Edit

Configurable by Worldserver.conf to enable/disable

---

Did you fix this issue? Go claim the $30 bounty on Bountysource.

[Ali-Khazaee]

I've find a way to implement this feature in ac without hardcore edits, After testing it i'll make a PR

[FrancescoBorzi]

This feature should be an addition to the CFBG

[Ali-Khazaee]

https://github.com/Ali-Khazaee/azerothcore-wotlk/tree/CFD

[FrancescoBorzi]

@Ali-Khazaee can you make it as an addition to the CFBG module?

we should avoid patching the core directly

[Winfidonarleyan]

I never understood why need to do cfbg and cfd together.
It's not the same thing, it's 2 different systems (bgs and dungeons) it really annoys me when say it's the same

[Winfidonarleyan]

@Ali-Khazaee, please move all code from the core to module

[Ali-Khazaee]

@FrancescoBorzi Alright, I'll make it as a separate module

[Ali-Khazaee]

I've just realized making this as module, Requires to add new hooks to the core

[FrancescoBorzi]

@Ali-Khazaee that's fine, you can add the hooks to the core when needed

[BarbzYHOOL]

A module for crossfaction dungeon finder, a module for crossfaction battlegrounds, a module for crossfaction ICC, what else??

When we enable crossfaction, we want all these things in ONE. All in one. Imo it should be in the core or all in one big module. In the core there is already crossfaction chat, grouping etc...........................

[FrancescoBorzi]

A module for crossfaction dungeon finder, a module for crossfaction battlegrounds, a module for crossfaction ICC, what else??

When we enable crossfaction, we want all these things in ONE. All in one. Imo it should be in the core or all in one big module. In the core there is already crossfaction chat, grouping etc...........................

you got a point, what I don't want is to break/complicate/alter the current behaviour when introducing such extra features

@Ali-Khazaee @BarbzYHOOL I don't mind if it's in the core, as long as when:

AllowTwoSide.DungeonFinder = 0

it has NO side effects at all

[BarbzYHOOL]

yes, it must be properly coded, if the author (most likely ali-khazaee) can't, then well a module will do the trick but in the end it should all be in the core OR we take all the crossfaction system OUT of the core and put all into a big module

[Ali-Khazaee]

https://github.com/Ali-Khazaee/azerothcore-wotlk/commit/b31b26c1dd98c27f16987f8f4ebd55113da28109

Could someone test & approve this commit ?

[Ali-Khazaee]

I've tried to keep this feature simple and not too much hardcore code

[Malow]

Isn't cross-faction dungeon finder already working by default in AC? At least on my server with the cross-faction battle ground module installed and all cross-faction flags enabled in the config I can queue with 2 Hordes and 3 Alliance to Random Dungeon and they all get matched together as a group.

[Helias]

@Malow, so can we close this?

Is there a way to move the bounty to another issue?