Azerothcore-wotlk: [Druid][Swipe(cat)/(bear)] Swipe does not proc Omen of Clarity clearcasting [$5 awarded]

[deadmage]

SMALL DESCRIPTION:

Swipe (Cat) and Swipe (Bear) do not proc Omen of Clarity clearcasting.

EXPECTED BLIZZLIKE BEHAVIOUR:

Swipe should proc Omen of Clarity Clearcasting

CURRENT BEHAVIOUR:

Swipe does not proc Omen of Clarity clearcasting

STEPS TO REPRODUCE THE PROBLEM:

1. Pull 5 to 10 mobs.
2. Spam Swipe(cat)/(bear)
3. Notice that Swipe does not proc clearcasting from Omen of Clarity

EXTRA NOTES:

BRANCH(ES):

master

AC HASH/COMMIT:

4b1436175a3b

OPERATING SYSTEM:

MODULES:

OTHER CUSTOMIZATIONS:

---

The $5 bounty on this issue has been claimed at Bountysource.

[andoys]

Bug confirmed! Druids in my server all complaining XD

[poszer]

What i can see the proc works fine. Could you check your combat log

[andoys]

HMMM i have to recheck. Or when i tested it was wrong way. But my players did report this. I apologize if it works.

[deadmage]

I swiped 10 times 20+ adds and it did not proc at all, i get procs from my AA only.

[deadmage]

Also i'm talking about the spell Swipe, not just swiping (AA) the target

[poszer]

Pull 5 to 10 mobs.
Spam Swipe(cat)/(bear)

Just tested, The proc works fine.
Also include your AC HASH/COMMIT:

[deadmage]

I noticed that during ulduar yesterday when i aoe'd the worms before Hodir.

[Ali-Khazaee]

Working on it, i will commit it

[Ali-Khazaee]

After some research, I've found out this talent should proc just at these points

1 Successful melee attack ( white damage )
2 Successful cast positive magic spell
3 Successful damage from harmful magic spell cast

So, feral's abilities are not MAGIC SPELL or HARMFUL MAGIC so this issue is blizlike behavior

anyway if you want to feral's abilities proc Omen try this:

https://github.com/Ali-Khazaee/azerothcore-wotlk/commit/a4d448dd59a74bb13cd1b9815370b86efe781604

[Ali-Khazaee]

@poszer Look at the screen you sent, Your character have done melee attack, so that melee attack cause Omen of clarity

[deadmage]

@Ali-Khazaee So I'm mistaking than, are u sure tho, cuz the spell says Each of the druids Damage, healing and auto attacks........

[Ali-Khazaee]

@deadmage What i said was what i extracted from spell work. So that must be blizlike behavior. If not then Ali-Khazaee@a4d448d is correct fix

[andoys]

@FrancescoBorzi @poszer can we put @Ali-Khazaee fix on pull?

[FrancescoBorzi]

@andoys yes he can open PR

[Ali-Khazaee]

Guys, I could create PR, But this isn't BlizLike! choice is yours

[andoys]

Wait i thought you said its Blizzlike?
Ahh i think i have read your message wrong. my apologies

[Ali-Khazaee]

https://github.com/azerothcore/azerothcore-wotlk/pull/2148

[talamortis]

Guys, I could create PR, But this isn't BlizLike! choice is yours

If this is not blizzlike then please close the PR as i am aware that azerothcore focus's on blizzlike content.

[Ali-Khazaee]

@talamortis You did it :D