Azerothcore-wotlk: Mage Water Elemental sometimes can't be dismissed and can't be resummoned maybe because of distance~

[andoys]

Mage Water Elemental sometimes can't be dismissed and can't resummon

SMALL DESCRIPTION:

Sometimes dead water elemental can't be dismissed and when we try to summon nothing happens.
but if we were able to dismiss the water elemental, we can summon again

EXPECTED BLIZZLIKE BEHAVIOUR:

When a water elemental dies, it should auto dismiss.
Water elemental should still summon even after u can summon again

CURRENT BEHAVIOUR:

Sometimes dead water elemental can't be dismissed and when we try to summon nothing happens.
but if we were able to dismiss the water elemental, we can summon again

STEPS TO REPRODUCE THE PROBLEM:

1. level a mage
2. get water elemental talent
3. try using waterelemental, let it die, sometimes u cant dismiss, it should auto dissmiss. after casing water elemental nothing happens

or

try mounting then doing it ?
summon ur water elemental
mount and run away
sometimes it doesnt move
then it cant be summoned again

EXTRA NOTES:

I sent a video to Poszer👑 of the actual bug happening

BRANCH(ES):

master

AC HASH/COMMIT:

Azerothcore rev. ded199dd7e7b+

OPERATING SYSTEM:

Ubuntu 16/18 etc.

MODULES:

OTHER CUSTOMIZATIONS:

[poszer]

Yeah, i saw your video. But i can't reproduce it :thinking:

[poszer]

Could you please test it without modules, or removing the modules one by one. It can be caused by one of them. Not sure, but i can't reproduce this in any way (Tested in combat, on die, on auto despawn, on coldsnap -> resummon, it works for me without problem).

[andoys]

it might be the same issue, i was able to produce the bug again by:

try mounting then doing it ?
summon ur water elemental
mount and run away
sometimes it doesnt move
then it cant be summoned again

[poszer]

it might be the same issue, i was able to produce the bug again by:

try mounting then doing it ?
summon ur water elemental
mount and run away
sometimes it doesnt move
then it cant be summoned again

Problem is distance. We should add follow speed like it's done for hunter pets

[andoys]

Try
letting pet fight monster
run awy far with or w/o mount
will produce same bug. haha

[lineagedr]

https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/scripts/Spells/spell_mage.cpp#L1049

Remove this statement.

[FrancescoBorzi]

@lineagedr please open a PR

[Viste]

and make crash in some cases. nice fixing!

[lineagedr]

and make crash in some cases. nice fixing!

I'm positive that removing the if (!pet->IsAlive()) line will not cause a crash.
I've had it on my core for over an year now and I have not encountered any crashes. Post crash log.

[andoys]

does
if (!pet->IsAlive())
fix this 100%?

Was crash a joke? or XD

[Voxstrasza]

Cannot reproduce as of 37d1f2be4729.

Water Elemental seems to have been reworked in December 2019, fixing the above issues - #2508

Closing.