Azerothcore-wotlk: VS release error

[czz3288067]

6>D:AZazerothcore-wotlksrcservergameEntitiesCreatureCreatureGroups.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss

13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
13> WheatyExceptionReport.cpp
9> instance_magisters_terrace.cpp
13>C:Program Files (x86)Windows Kits8.1Includeumdbghelp.h(1544): warning C4091: 'typedef ': ignored on left of '' when no variable is declared (compiling source file D:AZazerothcore-wotlksrccommonDebuggingWheatyExceptionReport.cpp)
13>C:Program Files (x86)Windows Kits8.1Includeumdbghelp.h(3190): warning C4091: 'typedef ': ignored on left of '' when no variable is declared (compiling source file D:AZazerothcore-wotlksrccommonDebuggingWheatyExceptionReport.cpp)
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(112): error C2001: newline in constant
9> boss_selin_fireheart.cpp
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(113): error C2059: syntax error: 'ACE_Singleton::instance'
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(113): error C2001: newline in constant
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(114): error C2143: syntax error: missing ')' before ';'
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(116): error C2001: newline in constant
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(117): error C2059: syntax error: 'ACE_Singleton::instance'
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(117): error C2001: newline in constant
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(118): error C2143: syntax error: missing ')' before ';'
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(120): error C2001: newline in constant
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(121): error C2059: syntax error: 'ACE_Singleton::instance'
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(121): error C2001: newline in constant
9> boss_vexallus.cpp
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(122): error C2001: newline in constant
9> instance_uldaman.cpp
13>D:AZazerothcore-wotlksrcserverauthserverMain.cpp(123): error C2143: syntax error: missing ')' before ';'

6>d:azazerothcore-wotlksrcservergameserverworldsocket.cpp(724): warning C4715: 'WorldSocket::ProcessIncoming': not all control paths return a value

14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (936). Save the file in Unicode format to prevent data loss
14> WheatyExceptionReport.cpp
14>C:Program Files (x86)Windows Kits8.1Includeumdbghelp.h(1544): warning C4091: 'typedef ': ignored on left of '' when no variable is declared (compiling source file D:AZazerothcore-wotlksrccommonDebuggingWheatyExceptionReport.cpp)
14>C:Program Files (x86)Windows Kits8.1Includeumdbghelp.h(3190): warning C4091: 'typedef ': ignored on left of '' when no variable is declared (compiling source file D:AZazerothcore-wotlksrccommonDebuggingWheatyExceptionReport.cpp)
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(121): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(122): error C2059: syntax error: 'ACE_Singleton::instance'
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(122): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(123): error C2143: syntax error: missing ')' before ';'
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(125): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(126): error C2059: syntax error: 'ACE_Singleton::instance'
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(126): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(127): error C2143: syntax error: missing ')' before ';'
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(129): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(130): error C2059: syntax error: 'ACE_Singleton::instance'
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(130): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(131): error C2001: newline in constant
14>D:AZazerothcore-wotlksrcserverworldserverMaster.cpp(132): error C2143: syntax error: missing ')' before ';'
15>------ Build started: Project: ALL_BUILD, Configuration: Release x64 ------
15> Building Custom Rule D:/AZ/azerothcore-wotlk/CMakeLists.txt
15> CMake does not need to re-run because D:/AZ/build/CMakeFiles/generate.stamp is up-to-date.
========== Build: 13 succeeded, 2 failed, 0 up-to-date, 0 skipped ==========

[Winfidonarleyan]

@czz3288067 Please add In your issue:

1. BRANCH:
2. AC HASH/COMMIT:
3. OPERATING SYSTEM: (Maybee win 8.1?)
4. MODULES:
5. OTHER CUSTOMIZATIONS:

And please look this: How to open an issue

[czz3288067]

BRANCH:azerothcore-wotlk（no change）
AC HASH/COMMIT:
OPERATING SYSTEM: win7 x64
MODULES:none
OTHER CUSTOMIZATIONS:none

[Winfidonarleyan]

Need AC HASH/COMMIT:

[czz3288067]

Author: AzerothCoreBot [e-mail] 2019-01-30 06:25:54
Committer: AzerothCoreBot [e-mail] 2019-01-30 06:25:54
Parent: d16c17c044c2b9acb6c61313ae775b7ba8bdde2e (feat(conditions): prevent adding bad contitions + align enums with TC (#1381))
Child: 4cd25ed0cacadd03b300d3d66fb66c24d8d96e4e ([Core / Spell] Fixed Amplify Damage)
Child: 0f67f9d5f0956bf82d5d6842fdee68f6f302a5d3 (Merge branch 'master' into staging)
Branches: master, remotes/origin/master, remotes/origin/staging, remotes/origin/talamortis-patch-1
Follows: v1.0.2
Precedes:

SHA1 ID:fc1fad4e32fedd486a8fe8ca30d2f8c3040b6d55

[czz3288067]

BOOST:boost_1_66_0-msvc-14.1-64
CMAKE:cmake-3.8.2-win64-x64
GIT:Git-2.20.1-64-bit
MYSQL:mysql-installer-community-5.6.43.0
OPENSSL:Win64OpenSSL-1_1_1a

[poszer]

Download this version of OpenSSL :
Click here

[talamortis]

you have the wrong version of OpenSSL. please look in the requirements to make sure you have all the correct stuff installed to configure AC before opening an issue.

[BarbzYHOOL]

Why do you guys tell him to use openssl 1.0.2??? Viste and Nefertum fixed openssl 1.1 on windows

https://github.com/azerothcore/azerothcore-wotlk/pull/1065
https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/cmake/macros/FindOpenSSL.cmake

[BarbzYHOOL]

Maybe it's still bugged

[FrancescoBorzi]

@Viste @Nefertumm can you please have a look at this?

[czz3288067]

I reinstalled the system and VS2017, solved most of the problems, except this

6>d:azazerothcore-wotlksrcservergameserverworldsocket.cpp(724): warning C4715: 'WorldSocket::ProcessIncoming': not all control paths return a value

Same as this:[VS] Compilation warning #1296

[czz3288067]

int WorldSocket::ProcessIncoming(WorldPacket* new_pct)
{
ACE_ASSERT (new_pct);

// manage memory ;)
ACE_Auto_Ptr<WorldPacket> aptr (new_pct);

const ACE_UINT16 opcode = new_pct->GetOpcode();

if (closing_)
    return -1;

// Dump received packet.
if (sPacketLog->CanLogPacket())
    sPacketLog->LogPacket(*new_pct, CLIENT_TO_SERVER);

try
{
    switch (opcode)
    {
        case CMSG_PING:
            return HandlePing (*new_pct);
        case CMSG_AUTH_SESSION:
            if (m_Session)
            {
                sLog->outError("WorldSocket::ProcessIncoming: Player send CMSG_AUTH_SESSION again");
                return -1;
            }
            return HandleAuthSession (*new_pct);
        case CMSG_KEEP_ALIVE:           
            if (m_Session)
                m_Session->ResetTimeOutTime(true);
            break;
        default:
        {
            ACE_GUARD_RETURN (LockType, Guard, m_SessionLock, -1);

            if (m_Session != NULL)
            {
                // Our Idle timer will reset on any non PING opcodes.
                // Catches people idling on the login screen and any lingering ingame connections.
                m_Session->ResetTimeOutTime(false);

                // OK, give the packet to WorldSession
                aptr.release();
                m_Session->QueuePacket (new_pct);
                return 0;
            }
            else
            {
                sLog->outError("WorldSocket::ProcessIncoming: Client not authed opcode = %u", uint32(opcode));
                return -1;
            }
        }
    }
}
catch (ByteBufferException &)
{
    sLog->outError("WorldSocket::ProcessIncoming ByteBufferException occured while parsing an instant handled packet (opcode: %u) from client %s, accountid=%i. Disconnected client.", opcode, GetRemoteAddress().c_str(), m_Session?m_Session->GetAccountId():-1);
    if (sLog->IsOutDebug())
    {
        sLog->outDebug(LOG_FILTER_NETWORKIO, "Dumping error causing packet:");
        new_pct->hexlike();
    }

    return -1;
}

ACE_NOTREACHED (return 0);

}

[czz3288067]

@Viste The error occurred after this update:
Core/Session: proper client timeout detection (#1232)

Please take a look, thank you.

[BarbzYHOOL]

at least it's not related to openssl, right? @czz3288067 you still use open ssl 1.1 right?

[czz3288067]

@BarbzYHOOL Yes, i still use Win64OpenSSL-1_1_1a.

[Viste]

@czz3288067 i know about 2 bugs in pr #1232 and for make fix to #1232 i need time related PR from staging branch,

[czz3288067]

@Viste OK，thank you!

[BarbzYHOOL]

Ok so openssl is detected then

[heijing-iw7]

I reinstalled the system and VS2017, solved most of the problems, except this

6>d:azazerothcore-wotlksrcservergameserverworldsocket.cpp(724): warning C4715: 'WorldSocket::ProcessIncoming': not all control paths return a value

Same as this:[VS] Compilation warning #1296

would you pls tell me how to fix the most of the problems, I most got the same issues as you