Azerothcore-wotlk: [Config] Crossfaction trading doesn't work (and never worked)

Created on 27 Nov 2016 · 24Comments · Source: azerothcore/azerothcore-wotlk

Description: In worldserver.conf:
AllowTwoSide.Trade = 1

Doesn't work entirely.
This affects all the emulators for atleast 3 years (trinitycore, mangos etc), so fixing it on AzerothCore would be quite nice.

Current behaviour: When you enable this parameter (gametype doesn't affect it), you can't trade with the opposite faction's player unless you are grouped with him. It displays "Target is unfriendly."

Expected behaviour: We should be able to trade with the opposite faction even if not in a group.

Steps to reproduce the problem:

Set AllowTwoSide.Trade = 1 in worldserver.conf
Create 1 alliance character on an account, and 1 horde character on another account
Meet together and you can't trade (type /trade) unless you're in a group.

Branch(es): All

Operating system: Debian 8 jessie / windows 7 (useless info)

Modules: No.

Other Customizations: None

Source

falzard

Most helpful comment

I think I had this fixed, i'll see when I get internet and post the fix

Inifield on 29 Nov 2016

🎉2

All 24 comments

There is no problem Please re confirm the team

boom8866 on 27 Nov 2016

😕1

what?

falzard on 27 Nov 2016

AllowTwoSide.Interaction.Chat = 1
AllowTwoSide.Interaction.Group = 1
AllowTwoSide.Trade = 1

Set the above and then try to test

boom8866 on 27 Nov 2016

👎2

It's already set to this (I enabled all AllowTwoSide) and it doesn't make sense anyway, you should try the issue before suggesting this!

falzard on 27 Nov 2016

👍1

Yes, its bugged, confirmed.

sucofog on 27 Nov 2016

👍1

Thanks Sucofog.
I tried to check if there was something related to this in TradeHandler.cpp but there was not, it was missing (there are 2 lines of code but it's not about this particular issue).

falzard on 27 Nov 2016

I don't think there's related to TradeHandler.cpp, its more related to config:

World.cpp
World.h

Let me check, missing config

sucofog on 27 Nov 2016

Change AllowTwoSide.Trade = 1 for AllowTwoSide.trade = 1

sucofog on 27 Nov 2016

Did you try it? Because I just tried by changing the conf line to AllowTwoSide.trade = 1 and it didn't change anything.

Update: It doesn't work even on a normal realm where characters are not in pvp state (their name is in blue)

Update 2: The AllowTwoSide.trade config is handled in TradeHandler if I'm not mistaking and the code here doesn't do anything for this issue!

falzard on 27 Nov 2016

if (!sWorld->getBoolConfig(CONFIG_ALLOW_TWO_SIDE_TRADE) && pOther->GetTeamId() != _player->GetTeamId()) { SendTradeStatus(TRADE_STATUS_WRONG_FACTION); return; }

The only part about this issue is above.

_Bonus: Found this_

void LFGMgr::SetTeam(uint64 guid, TeamId teamId)
{
    if (sWorld->getBoolConfig(CONFIG_ALLOW_TWO_SIDE_INTERACTION_GROUP))
        teamId = TEAM_ALLIANCE; // @Not Sure About That TeamId is supposed to be uint8 Team = 0(@TrinityCore)

    PlayersStore[guid].SetTeam(teamId);
}

_So everybody is considered alliance? Just asking_

falzard on 27 Nov 2016

f m no 6wkqhl1f a3eg
j5inrsh4 3h2ux kc zs8r

Why?

I will be opposed?

boom8866 on 28 Nov 2016

👎1

#

PLAYER INTERACTION

TalentsInspecting = 1

#

boom8866 on 28 Nov 2016

Ok boom8866, thank you for trying to help us but I already stated this in the issue. Try it WITHOUT A GROUP, or just wait for someone with real knowledge to answer, please.

falzard on 28 Nov 2016

I think I had this fixed, i'll see when I get internet and post the fix

Inifield on 29 Nov 2016

🎉2

It would be nice @Blumfield ! :)

sucofog on 2 Dec 2016

@Blumfield did you get internet back? :P

falzard on 10 Dec 2016

wowscrnshot_031017_133109
wowscrnshot_031017_133112
All is ok man i don't know why it not work for you

Viste on 10 Mar 2017

@Viste Try that without being in a group, that is what should be right, trading with opposite faction without being in a group/band

sucofog on 10 Mar 2017

@sucofog ok i try later

Viste on 10 Mar 2017

without party don't work

Viste on 10 Mar 2017

Its corret i think, party make faction 3 and make other factions in one

Viste on 10 Mar 2017

Looked alot through the source code didn't find anything, most likely client bug?

Somewhere it checks if players are same faction before trading.
If you do .gm on on both chars it sets their faction to 35 and the trade works.

lineagedr on 22 Oct 2017

It's probably a client limitation since the client is able to check
factions before server (improving performances)

Il 22 Ott 2017 5:02 AM, "lineagedr" notifications@github.com ha scritto:

Looked alot through the source code didn't find anything, most likely
client bug?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/azerothcore/azerothcore-wotlk/issues/266#issuecomment-338447528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI-lP51mG0-Cgo_jWhVa1wOqME8FPjyks5surBegaJpZM4K9MA3
.