Axonframework: Ability to use jdbc Timestamp in event- and snapshot tables

[ovstetun]

The ability to modify all SQL introduced in PR #1321 has at the same time removed the choice to have the timestamp column in the database as a sql-timestamp. Previously this was possible by overloading JdbcEventStorageEngine#writeTimestamp. See https://github.com/AxonFramework/AxonFramework/blob/a0f1e8d86fe67de02634c3fe718dc9989d7bc7a5/eventsourcing/src/main/java/org/axonframework/eventsourcing/eventstore/jdbc/JdbcEventStorageEngine.java#L728
It seems this function is currently unused, while the inverse JdbcEventStorageEngine#readTimestamp works as before.

We have timestamp in our databases and it would be great if this could be reintroduced.

[lfgcampos]

Hi @ovstetun, thanks for filling in this issue.
You are right, it was changed on the mentioned PR and it shouldn't.

Would you mind providing a PR to it?
If not, I will put it on my queue and try to tackle it as soon as possible.

[ovstetun]

I just pushed a PR for this. I'm not able to build the whole repository locally (as org.axonframework:axon-server-connector:jar:4.4-SNAPSHOT is not available for maven to download), but all core modules build successfully.

[smcvb]

Thanks a lot for filing and fixing this issue @ovstetun! The help is much appreciated.

[ovstetun]

My pleasure :)
We've been using Axon for some years now, so it's nice to help and give
something back :)

On Mon, Jun 22, 2020 at 10:55 AM Steven van Beelen [e-mail]
wrote:

Thanks a lot for filing and fixing this issue @ovstetun
https://github.com/ovstetun! The help is much appreciated.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AxonFramework/AxonFramework/issues/1453#issuecomment-647381895,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAKEUM6O27JM6OE335HIILRX4MBPANCNFSM4OBPZI2Q
.

--
TronD

[smcvb]

Changed milestone from 4.4 to 4.3.4 and cherry picked this solution to axon-4.3.x, as it rightfully belongs in a bug release.