Aws-xray-sdk-node: Support for AWS SDK for JavaScript v3

[anvar]

Is there a branch parked somewhere with support for the new JavaScript AWS SDK? The new SDK uses middleware to intercept and transform requests/responses, which is a bit different to how the xray-sdk hooks into the 2.x version. If not, happy to get started and send a PR, just thought I would check beforehand.

Thanks!

[willarmiros]

Hi @anvar,
We are not yet developing support for AWS SDK for JS v3. We'd be open to a pull request if you're interested. The only caveats are that we'd like to keep dependencies to an absolute minimum, although that shouldn't be an issue with v3's modular design. We'll also need to discuss with the AWS SDK team about the stability of the middleware APIs before we can mainline our own middleware, since they are still in beta.

Otherwise, contribute away!

[anvar]

Great, thank you, I will have a look!

[trivikr]

Update: The general availability of the AWS SDK for JavaScript, version 3 (v3) was announced on December 15th, 2020.

[awssandra]

Reviewing pull request in flight.

[bfaulk96]

Hey all, I noticed https://github.com/aws/aws-xray-sdk-node/pull/386 got merged, but it seems I still get the TypeError: service.customizeRequests is not a function error when trying to capture the Dynamo Document Client from the sdk v3... Any updates?

[willarmiros]

@bfaulk96 see #395

[willarmiros]

Released in 3.3.0!

[willarmiros]

Reopening because we had to temporarily rollback AWS SDK V3 support in patch release v3.3.1 to address #411. We are actively working on another patch that will add back AWS SDK v3 support in 3.3.2.

[bfaulk96]

Any updates on this being re-implemented?

[awssandra]

We are actively addressing this to re-release. Stay tuned!

[jwoehrle]

I've tested some of my code with 3.3.3... works now as expected :tada:

Thank you!

[willarmiros]

As @jwoehrle said, AWS SDK v3 support is here to stay as of v3.3.3. Closing this out.