Aws-sdk-js: ServiceConfigurationOptions.endpoint type should allow AWS.Endpoint

[kyle-johnson]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• [x] I've gone though Developer Guide and API reference
• [x] I've checked AWS Forums and StackOverflow for answers
• [x] I've searched for previous similar issues and didn't find any solution

Describe the bug
ServiceConfigurationOptions.endpoint is defined as type string, but the AWS.Endpoint documentation suggests an AWS.Endpoint object is valid as well:

var ep = new AWS.Endpoint('awsproxy.example.com');
var s3 = new AWS.S3({endpoint: ep});

SDK version number
v2.518.0

Expected behavior
Seems the type should be:

endpoint?: string | Endpoint;

[ajredniwja]

Hey @kyle-johnson,

Thank-you for reaching out, it can be marked as a feature request, you are welcomed to open a PR about this.

[esilkensen]

Hi @ajredniwja, I opened a PR for this here: #2923

[ajredniwja]

Hey @esilkensen,

Thank-you for the PR, the team will review the PR and make a decision on merging it or not.

[github-actions[bot]]

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

[esilkensen]

I think this issue is still valid, though it has been a year and my PR was never reviewed.

[ajredniwja]

Apologies for the delay, I merged the PR @esilkensen.