Aws-sdk-java: Add module-info.java

Created on 18 Oct 2017 · 10Comments · Source: aws/aws-sdk-java

So that projects depend on this can be published to a public artifact repository.
Note that this is not breaking backward compatibility. All codes except this file can be still compiled in Java 6.

feature-request

Source

hrchu

👍1

Most helpful comment

Using automatic modules only works in some cases because there are split packages. For example, the package com.amazonaws.auth exists in both aws-java-sdk-s3 and aws-java-sdk-core giving the following error:

error: module demo reads package com.amazonaws.auth from both aws.java.sdk.core and aws.java.sdk.s3

polle on 15 Jan 2018

👍10

All 10 comments

error: module demo reads package com.amazonaws.auth from both aws.java.sdk.core and aws.java.sdk.s3

polle on 15 Jan 2018

👍10

so whats the solution for now ?

hookla on 23 Apr 2018

👍2

The real issue here is split packages, effectively rendering the SDK unusable in a JPMS (jdk9 or later) runtime.

rferreira on 27 May 2018

👍1

A relatively low-effort way of addressing this is to add an Automatic-Module-Name value to the MANIFEST.MF in each JAR file. This could be done in maven by adding something like:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-jar-plugin</artifactId>
  <configuration>
    <archive>
      <manifestEntries>
        <Automatic-Module-Name>com.amazonaws.aws.java.sdk.iam</Automatic-Module-Name>
      </manifestEntries>
    </archive>
  </configuration>
</plugin>

This doesn't get around the modules dependencies, but it helps ensure that we don't get module naming collusions, etc..

damnhandy on 2 Jul 2018

Any update(s) on this? I have some code being used from v1 (as it doesn't exist yet in v2), and I'm encountering a split package on com.amazonaws.auth.