Aws-sdk-go: SDK again unusable with dep due to case sensitivity?

[brikis98]

Version of AWS SDK for Go?

1.12.42

Version of Go (go version)?

go version go1.9.2 darwin/amd64

What issue did you see?

Can't run dep init with latest SDK on OS X, as you get this error:

grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/aws/aws-sdk-go: : exit status 128

This looks very similar to #1540, so perhaps someone made a commit with case sensitivity issues again?

Steps to reproduce

The code is private, but I believe the repro steps are:

1. Use the AWS SDK in some .go files
2. Run dep init

[ghost]

Same here

[sudhirj]

No so much case sensitivity, as models/apis/sagemaker/2017-07-24/waiters-2.json - the dep git operations keep getting stuck on this file for some reason - it either shows up as modified when it shouldn't be, or has whitespace changes that it should not have.

[sudhirj]

Is there some sort of hook that runs whenever a branch is checked out? This is causing modifications to the files when checking out v1.12.42, while v1.12.41 checks out cleanly.

[jasdel]

Thanks for creating this issue @brikis98 The release v1.12.42 yesterday included an updated for SageMaker service which was committed with an alternate naming scheme incorrectly.

This was fixed in, #1686. A release has not been cut yet that includes this fix. A release will be cut for this fix today.

[brikis98]

Awesome, thanks!

Might be worth looking into a linting tool that catches these sorts of errors. Would probably be useful for all Go projects.

[jasdel]

Thanks for the suggestion. We're working to improve the reliability of how these model folder names are generated and sourced to be more stable.

Release v1.12.43 should be cut shortly once the travis checks finish.

[jasdel]

Thanks for reporting this issue @brikis98, @Atanas-Kanchev, and @sudhirj. This issue is now tagged in release v1.12.43.