Aws-load-balancer-controller: Provide human understandable target group names

Created on 23 Feb 2019 · 14Comments · Source: kubernetes-sigs/aws-load-balancer-controller

I would like to use CloudWatch to gather metrics dealing with various Target Groups behind an ELB but is very difficult to at-a-glance understand which Target Group is having issues due to the UUIDs/hashes being generated as the names currently. It would be nice to have some sort of configurable option to specify the name or at least a prefix to denote what Kubernetes service you are using (default value to a combination of servicer name + namespace would be nice).

Source

sdavids13

👍2

Most helpful comment

@M00nF1sh Looking forward to a release with this feature. Thanks

rverma-nikiai on 26 May 2019

👍4

All 14 comments

one option is by using the --alb-name-prefix, we get the option to prefix the alb and the target group with a useful name. the alb and target group then gets created with <prefix-name>-......

shankarramshivram on 8 Mar 2019

I have been planing to change the targetGroup name to k8s-{namespace:8}-{name:8}-{uuid:10}.
uuid is hash consisted of clusterName, targetType, protocol, etc. Which should be good enough for general use cases.
(actually in my NLB PR https://github.com/kubernetes/kubernetes/pull/74910, i did that name change for NLB targetGroups).

For Ingress controller, the --alb-name-prefix have forbids me to do so, needs to figure out the real use case of such flag.

M00nF1sh on 8 Mar 2019

👍3

Is the {name} the name of the k8s service configured in the Ingress Controller? If so, that should be sufficient being able to identify what the target group is associated with.

On Mar 8, 2019, at 5:02 PM, M00nF1sh notifications@github.com wrote:

I have been planing to change the targetGroup name to k8s-{namespace:8}-{name:8}-{uuid:10}.
uuid is hash consisted of clusterName, targetType, protocol, etc. Which should be good enough for general use cases.
(actually in my NLB PR kubernetes/kubernetes#74910, i did that name change for NLB targetGroups).

For Ingress controller, the --alb-name-prefix have forbids me to do so, needs to figure out the real use case of such flag.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

sdavids13 on 9 Mar 2019

Do we have a solution for this?

rverma-nikiai on 29 Mar 2019

@rverma-nikiai
What's your ideal name for targetGroups?
Will k8s-{namespace:8}-{name:8}-{uuid:10} be good enough for you?

M00nF1sh on 29 Mar 2019

@M00nF1sh I would prefer k8-{ing/svc name}-{namespace}-{UUID:10}. Your suggestion is very good too.

rverma-nikiai on 15 Apr 2019

Also it would be nice that once we deploy the fix it should take care of deleting the existing random names and creating new target groups

rverma-nikiai on 15 Apr 2019

@M00nF1sh Looking forward to a release with this feature. Thanks

rverma-nikiai on 26 May 2019

👍4

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot on 24 Aug 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot on 23 Sep 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

fejta-bot on 23 Oct 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.