Currently it appears the behavior is that the controller creates the necessary AWS objects for an ALB (Security Groups, Target Groups, etc). Then as it runs it also syncs the configuration periodically so if a security group managed by the alb-ingress-controller is changed manually in the AWS console those changes are overwritten.
This would be similar in effect to the option given by external-dns policy=upsert-only or policy=sync.
will take a look for this.
Personally I like the idea of only reconcile rules managed by alb controller, maybe by adding a special description for the rules. like [k8s.io/description]: rules to support ingress traffic. Then any rule not prefixed with [k8s.io/description] are untouched.
The upsert annotation is about the only way I can get behind this. It's an inherently risky proposal to allow drift from the managed ALB and the ingress definition, akin to manually modifying your pods after they are deployed. For whatever reason this keeps coming up though. The users would need to understand that once they set upsert-only on an ingress they are signing up for an unexpected reshuffling of rules or settings when an ingress is updated.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
/remove-lifecycle stale
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
The upsert annotation is about the only way I can get behind this. It's an inherently risky proposal to allow drift from the managed ALB and the ingress definition, akin to manually modifying your pods after they are deployed. For whatever reason this keeps coming up though. The users would need to understand that once they set
upsert-onlyon an ingress they are signing up for an unexpected reshuffling of rules or settings when an ingress is updated.
can you please let me know how did you solve this issue?
I am trying to manully add some listeners as well as modifying security groups.But it gets deleted after a while.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen.
Mark the issue as fresh with/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Most helpful comment
The upsert annotation is about the only way I can get behind this. It's an inherently risky proposal to allow drift from the managed ALB and the ingress definition, akin to manually modifying your pods after they are deployed. For whatever reason this keeps coming up though. The users would need to understand that once they set
upsert-onlyon an ingress they are signing up for an unexpected reshuffling of rules or settings when an ingress is updated.