Aws-data-wrangler: columns_comments in s3.to_csv will not work as expected

Created on 28 May 2020  路  3Comments  路  Source: awslabs/aws-data-wrangler

Describe the bug
The comment here https://github.com/awslabs/aws-data-wrangler/blob/master/awswrangler/s3.py#L684
said that dataset=False will not be able to use with these arguments: database, table, description, parameters, and columns_comments. But columns_comments is not a if else statement in this part.

To Reproduce
When a user called to_csv with dataset=False and columns_comment={"foo": "bar"}, this method can run normally without any exception.

Minor Release bug

All 3 comments

Hey @bryanyang0528 thank you one more time!

P.S.

I've just added black and isort checks in the statical check that runs on Github Actions (commit above).
So, make sure that you run this commands before any push:

cd testing/
./validations.sh

@igorborgest No problem, thank you!

Changes released on version 1.4.0

Thanks!

Was this page helpful?
0 / 5 - 0 ratings