Aws-cli: 'aws cloudformation package' should include symlinked files

[Pelto]

Hi,

We are working with the serverless application model and using Node.JS for our work. Since we have a lot shared code we have decided to outsource them into small libraries. However we are unable to fully upgrade to NPM 5 due to how local dependencies are used. Example on how our package.json may look like:

{
  "name": "app",
  "version": "0.0.1",
  "description": "Local stuff",
  "private": true,
  "dependencies": {
    "async": "^2.5.0",
    "local-dependency": "file:../local-dependency"
  }
}

After running npm install my node_modules now contains the following:

drwxr-xr-x    5 johannes  staff   170B Oct 17 11:16 .
drwxr-xr-x   10 johannes  staff   340B Oct 17 11:16 ..
drwxr-xr-x   87 johannes  staff   2.9K Oct 17 11:15 async
lrwxr-xr-x    1 johannes  staff    22B Oct 17 11:16 local-dependency -> ../../local-dependency
drwxr-xr-x  640 johannes  staff    21K Oct 17 11:15 lodash

When running aws cloudformation package the symlinked dependency will not be part of my packaged file.

[ghost]

That would be really nice. +1

[sanathkr]

Just approved the PR. @JordonPhillips can we get this merged?

[knakayama]

Is there any update? I need this feature in my project.

[brunomorency]

@knakayama see https://github.com/aws/aws-cli/pull/2901, looks like it's close to being merged.

[ASayre]

Good Morning!

We're closing this issue here on GitHub, as part of our migration to UserVoice for feature requests involving the AWS CLI.

This will let us get the most important features to you, by making it easier to search for and show support for the features you care the most about, without diluting the conversation with bug reports.

As a quick UserVoice primer (if not already familiar): after an idea is posted, people can vote on the ideas, and the product team will be responding directly to the most popular suggestions.

We’ve imported existing feature requests from GitHub - Search for this issue there!

And don't worry, this issue will still exist on GitHub for posterity's sake. As it’s a text-only import of the original post into UserVoice, we’ll still be keeping in mind the comments and discussion that already exist here on the GitHub issue.

GitHub will remain the channel for reporting bugs.

Once again, this issue can now be found by searching for the title on: https://aws.uservoice.com/forums/598381-aws-command-line-interface

-The AWS SDKs & Tools Team

[jamesls]

Based on community feedback, we have decided to return feature requests to GitHub issues.

[abadyan-vonage]

This is important for us as well, we have a git repo with lambdas and containers which share code. For the sake of packaging we tried using symlinks so as to not duplicate code or create external copying tasks but I just discovered this doesn't work.
Can this please be added?

[et304383]

This is a recurring theme of the AWS tools breaking symlinks. Stop messing with our directory structure. Argh.

[ispyinternet]

YES PLEASE.