Aws-cdk: [aws-lambda-nodejs] NodejsFunction broken on v1.48.0

Created on 1 Jul 2020 · 10Comments · Source: aws/aws-cdk

The NodejsFunction construct is broken on v1.48.0 because it wrongly searches for the closest package.json.

Error Log

@parcel/core: Could not find target with name "cdk-lambda"

Environment

CLI Version : 1.48.0
Framework Version: 1.48.0
Node.js Version: all
OS : all
Language (Version): all

Other

Already working on a PR with fix.

This is :bug: Bug Report

@aws-cdaws-lambda-nodejs bug needs-triage

Source

jogold

👍3

All 10 comments

@eladb can you pin this issue?

jogold on 1 Jul 2020

@jogold when is this likely to be released?

tgandrews on 1 Jul 2020

@jogold when is this likely to be released?

https://github.com/aws/aws-cdk/releases/tag/v1.49.0

jogold on 2 Jul 2020

🎉1

Thanks for this and your work on CDK. It’s so much better than the
alternatives.

On Thu, 2 Jul 2020 at 19:18, Jonathan Goldwasser notifications@github.com
wrote:

@jogold https://github.com/jogold when is this likely to be released?

https://github.com/aws/aws-cdk/releases/tag/v1.49.0

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/aws/aws-cdk/issues/8837#issuecomment-653154286, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABMFJZSY3GF4IOS5R3JHELRZTFORANCNFSM4ONQHCFA
.

>

tomandrews.co.uk

tgandrews on 2 Jul 2020

👍1

on cdk 1.49.1 version still not working with Nodejs Function parcel error, we have to stick with 1.47.1

Node version: 12 latest on Codebuild
npx: installed 8 in 1.38s
Cannot find project root. Please specify it with `projectRoot`.

ookangzheng on 7 Jul 2020

@ookangzheng can you share your folder structure? Is it a git repository?

jogold on 7 Jul 2020

This change likely broke our deployment - it does not take in account monorepos with private packages and lerna, which worked before this change.

gergan on 13 Jul 2020

Hey @gergan, can you open a separate issue for this, detailing your setup?

I'm using the construct in the exact same configuration (a monorepo with private packages and lerna). Would like to see where is the issue for your setup.

jogold on 13 Jul 2020

@jogold Thanks for the fast response I have created a new issue and tried to explain our setup, if you need more information I'll be glad to provide it to you.

gergan on 13 Jul 2020

For anyone who comes here from Google like I did - I had this problem because I didn't have a Git repo set up (I was testing something out). When I did git init that fixed the problem. See https://github.com/jogold/aws-cdk/blob/master/packages/@aws-cdk/aws-lambda-nodejs/lib/bundling.ts#L107 .