Aws-cdk: Instructions in `Contributing.md` for pulling the superchain docker image don't work

[mpiroc]

The relevant instructions:

eval $(aws ecr get-login --no-include-email)
IMAGE=260708760616.dkr.ecr.us-east-1.amazonaws.com/superchain:latest
docker pull ${IMAGE}
docker run --net=host -it -v $PWD:$PWD -w $PWD ${IMAGE}

The error:

Error response from daemon: pull access denied for 260708760616.dkr.ecr.us-east-1.amazonaws.com/superchain, repository does not exist or may require 'docker login'

Ideally, the superchain image should be published to Docker Hub. In the meantime, we should fix these instructions to unblock potential contributors.

[mpiroc]

@costleya

[hassankhan]

Big +1, really wanted to get a PR in this weekend but can't figure out how to get set up.

[rix0rrr]

A simple solution would be to make the image pullable by anyone, which is easy enough to do.

However, I am told there might be legal implications and I'm not 100% up on the details enough to do it myself right now, I'm sorry. Calling @eladb to share his opinion on this next week.

[toddwildey]

export AWS_DEFAULT_REGION="us-west-2" # Your region here
export AWS_ACCOUNT_ID="1234567890" # Your account ID here

git clone [email protected]:awslabs/superchain.git
cd superchain
./build.sh
eval $(aws ecr get-login --no-include-email --region $AWS_DEFAULT_REGION)
docker tag superchain $AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com/superchain:latest
docker push $AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com/superchain:latest

[rix0rrr]

This will work only for members of the awslabs organization, unfortunately, as the superchain repository and image are private. Until we figure out whether it's okay to release this, the superchain contains these pieces of software, so either building your own image with these or installing them on your host system will also unblock you:

node.js-8.11.0
java-openjdk-8
dotnet-core-2
python-3.6.5
ruby-2.5.1
rsync

[hassankhan]

Aww that's a shame, I'd rather not have to install all this on my host system 😞

Is there an ETA on when you might reach a decision on the Docker image?

[rix0rrr]

I'm putting the gears into motion. Stay tuned.

[rix0rrr]

Thinking about it some more, you can quite effectively develop for the CDK using only TypeScript using only locally-installed npm packages.

The instructions don't really mention this, but you can probably get by with

$ ./install.sh
$ ./build.sh

from the root, outside a Docker image (this is what I do).

[hassankhan]

Thanks for the pointers, I'll give it a go 👍

[Doug-AWS]

Can we close this?

[hassankhan]

Yep I think so, this issue is now irrelevant since the CONTRIBUTING.md guide does not require the private Docker image any more.

[Doug-AWS]

Assigned to Michael to close as he opened it.

[NGL321]

@rix0rrr Status on this?

[SomayaB]

Closing this issue since there hasn't been activity on it in a while. Feel free to reopen.