@awesomeWM/write-access All of you (including me) seem to be busy doing other things than AwesomeWM. The graph in https://github.com/awesomeWM/awesome/graphs/contributors looks pretty low for the last year.
So... should we switch from requiring two reviews on a PR to only one? (Although that wouldn't change anything currently since we also require a successful Travis build and non-negative coverage change.)
Should we give more people write access in this organisation?
Who would be candidates? More importantly, who also "self-nominates" in the sense of "I want to do this and I might have some time to do reviews"?
(Dear reader, we are using mergify.io, which means that a PR which meets some requirements is automatically merged. The requirements include two approving reviews.)
I'm obviously biased (I'm only human), but aire-one, kolo1337, SirAidali, and HumblePresent seem to be names that I often see answer questions on https://www.reddit.com/r/awesomewm/. This is the best metric for "might know what they are doing and could review patches here" that I came up with.
Thanks for starting this @psychon!
I didn't follow anything for the last years so I don't have anything to say here.
As a first step, you could probably lower the barrier of review for core contributors with a rule such as:
- name: automatic merge
conditions:
- label!=no-mergify
- '#approved-reviews-by>=1'
- author=@awesomeWM/write-access
- status-success=Travis CI - Pull Request
- status-success=codecov/patch
- status-success=coverage/coveralls
actions:
merge:
method: merge
My 2c!
i'm agree it's good idea to wait for self-nominations
For some reason, I thought that somehow, you know each other. I mean, _know_ as in _for real_, in an IRL way. So I'm kinda surprised you would accept random people from the internet as co-maintainer.
As @psychon mentioned, for the last few years, I tried to help other users by submitting PRs to fix bugs and improve the user documentation. I also try to be active on reddit and the unofficial discord (IRC and stackoverflow are platforms I'm too lazy to create an account and regularly check on). I also do PRs reviews from time to time, I don't know if it's helpful to you guys, but it makes me feel kinda useful to the project.
All in one: I'd love to take this opportunity to candidate! I would be very happy to be part of the team.
About the mergify requirements, I'm not so much into switch to only 1 approval as it puts fewer trusted eyes on the project changes... But realistically, most of the PRs doesn't require so much care. So I guess it's a valid option.
I'd like to also add the following note while we have a discussion where all the project members are in: Thank you for all the work you all (have) put in awesome! 鉂わ笍
For some reason, I thought that somehow, you know each other. I mean, know as in for real, in an IRL way. So I'm kinda surprised you would accept random people from the internet as co-maintainer.
The open-source ecosystem would be long dead if that was true 馃槅
Thanks for helping @Aire-One!
(I'll hide this comment as off-topic after I submitted it.)
For some reason, I thought that somehow, you know each other.
Heh. History time!
"Back then" I tried out AwesomeWM and quickly gave up again. I think I needed two or three attempts before I stuck with it.
According to git, my first commit was "fix a (harmless) x protocol error message". This was just a small patch that I wrote to the mailing list back then and jd merged it. Wow, March 17th 2009. Soon will be my 12th Awesome Anniversary.
As time continued, I wrote more patches, jd merged more patches and eventually I somehow "inherited" AwesomeWM from jd. I do not know when others come into play, but there are many people that worked on it. I never met any of them or even talked to them, with one exception: I met Daniel in Berlin some years back because I happened to be there. I still remember that he said that I am younger than he expected. :-)
Anyway, yeah, as jd said: This is how open source works. AwesomeWM is not the only project that I "stole" this way.
All in one: I'd love to take this opportunity to candidate! I would be very happy to be part of the team.
Thanks.
Okay, to make this a bit more plannable: Please ping me beginning of march and I'll add you to the "Write access" team (I bet that name comes from GitHub...). Until then, everyone else still gets to cry "no! do not do that!" (but I do not expect any complaints.)
Also, everyone else: Feel free to still speak up. (Does this issue count as fixed by adding one person to the team?)
The open-source ecosystem would be long dead if that was true 馃槅
I feel naive now... 馃槀
Heh. History time!
Thanks for that! I love soooo much this kind of backstories.
Please ping me beginning of march and I'll add you to the "Write access" team (I bet that name comes from GitHub...). Until then, everyone else still gets to cry "no! do not do that!"
Fair enough. I guess you mean "beginning of April" tho, given we're the 5th of March.
As time continued, I wrote more patches, jd merged more patches and eventually I somehow "inherited" AwesomeWM from jd.
Haha, I'll always remember "your face" (on IRC, ok) when I gave you commit access and you were like "oh noes this is too much you still need to review my patches!" 馃榿
Hi, I'm SirAiedail on Reddit (@SirAiedail is a dummy account). I just got word of this from another Awesome user (Hi, bi :wave:).
While I have been a mere lcpz/awesome-copycats user for a few years, I did start looking into creating a custom setup a few months back, and, as psychon said, I've been getting more involved in the community as well.
I'd be happy to help out where I can. Maybe not so much on the magicC side (yet?), but Lua should be fine 馃槄
Actually, the main reason why I didn't look into the bugs I reported myself so far, was the fact that I tried to build from source once, failed, and didn't try again. I guess, I'll fix that first.
And maybe work on my setup, so that one day I have something to show off in #1395 :smile:.
Anyways. I'm not sure if I would give myself a ContributorMember badge already, but feel free to shoot questions or PR reviews my way. Or issues, once I have a dev build set up.
Most helpful comment
For some reason, I thought that somehow, you know each other. I mean, _know_ as in _for real_, in an IRL way. So I'm kinda surprised you would accept random people from the internet as co-maintainer.
As @psychon mentioned, for the last few years, I tried to help other users by submitting PRs to fix bugs and improve the user documentation. I also try to be active on reddit and the unofficial discord (IRC and stackoverflow are platforms I'm too lazy to create an account and regularly check on). I also do PRs reviews from time to time, I don't know if it's helpful to you guys, but it makes me feel kinda useful to the project.
All in one: I'd love to take this opportunity to candidate! I would be very happy to be part of the team.
About the mergify requirements, I'm not so much into switch to only 1 approval as it puts fewer trusted eyes on the project changes... But realistically, most of the PRs doesn't require so much care. So I guess it's a valid option.
I'd like to also add the following note while we have a discussion where all the project members are in: Thank you for all the work you all (have) put in awesome! 鉂わ笍