Ava: Explore storing an error object, rather than directly capturing a stack trace

[novemberborn]

For asynchronous assertions we capture a stack trace before the assertion is run. Inspired by this comment by @alxandr we should explore storing an error object, and reading the stack trace later if it's actually necessary:

… instead of passing the stack trace itself, an error object could be passed. This has less performance impact, because then the stack trace is only generated on demand (this might even be something that could improve the performance of your existing async tests).

See lib/test.js and lib/assert.js.

---

IssueHunt Summary

mihai-dinu has been rewarded.

Backers (Total: $40.00)

• issuehunt ($40.00)

Submitted pull Requests

- #2130 Store an error object in AssertionError rather than a stack trace

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
  

  - Need some help from other developers? Add your repositories on IssueHunt to raise funds.

IssueHunt has been backed by the following sponsors. Become a sponsor

[Alxandr]

This may not work on older node versions btw.

[monicabhalshankar]

Hi, I am new to contributing to here
I would like to work on this bug
I have got an idea of the issue that is present currently, but I might need some help testing the code after I modify it. @novemberborn can you please provide some info.

[novemberborn]

@monicabhalshankar great, it's all yours!

Could you be more specific in what info you need? Feel free to open a PR with what you've got so far.

[monicabhalshankar]

@novemberborn so far I went through the 2 files that were linked above
My understanding is we can modify the test.js file to generate the stack trace only when plancount and assert count are equal.
Apart from this I did not find if any other modification can be done
Is this what is expected ? Or I should be considering some other scenarios as well?

[novemberborn]

@monicabhalshankar this issue links to existing stack-getting-methods. The proposal is to capture the stack in an object, and return that object, rather than returning the stack string. Then elsewhere we access the stack from the returned object, only when needed.

[JasonRitchie]

I believe I understand the request. I'm also a beginner, but I'd be willing to assist. @monicabhalshankar let me know if there's anything I can do to help.

[Sharan-ram]

@novemberborn i'm a beginner to open source, is this issue still open to work on?would like to make a contribution.

[novemberborn]

Are you still working on this @monicabhalshankar? Given that you've been quiet here for a while, I hope you don't mind if @Sharan-ram has a go at this as well?

@Sharan-ram would be great if you could give this a go. There's a chance @monicabhalshankar is nearly done with this of course.

[javiroberts]

Hey is this already done? May I give it a go?

[monicabhalshankar]

Sorry have been busy for a while, so could not work on the issue.
Please feel free to give it a go

[sainalshah]

@novemberborn I'm a beginner, and I'd like to work on this issue.

[novemberborn]

Of course @sainalshah, it's all yours.

[Jolo510]

@sainalshah Let me know if you'd like to collaborate! I'm also a beginner to open source and would like to contribute as well.

[sainalshah]

@Jolo510 yeah sure, but how u wanna collaborate?

[Jolo510]

@sainalshah Sweet! Lets take a look at it individually first then come together and discuss it? We should take this chat off of this thread.

[sainalshah]

@Jolo510 we can have this chat on hangouts

[Jolo510]

@sainalshah Sure! Send me an email at [email protected]

[peterr101]

Hi, I am new to open source, but I would like to contribute here if possible?

[novemberborn]

Go for it, @peterr101!

[Ullauri]

Safe to say no one is working on this?

[novemberborn]

@Ullauri yea, looks available. Go for it!

[Ullauri]

Sounds good. I think I understand what this request is asking for. Either way, ill open up a PR for it when I'm done.

[IssueHuntBot]

@issuehunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[mihai-dinu]

I'd like to take a stab at this. I will open a PR with some preliminary/not unit tested code to see if I understood the requirement right.

[ulken]

@novemberborn Maybe just the bot is to blame, but shouldn't @mihai-dinu been awarded the bounty for this? Issue is still up on IssueHunt.

[novemberborn]

@ulken good find. I'm not sure… @sindresorhus?

[issuehunt-app[bot]]

@sindresorhus has rewarded $36.00 to @mihai-dinu. See it on IssueHunt

• :moneybag: Total deposit: $40.00
• :tada: Repository reward(0%): $0.00
• :wrench: Service fee(10%): $4.00