Autoscaler: Helm chart doesn't add service account annotations

[lexsys27]

I want to install cluster autoscaler using the latest Helm chart. Here is my values.yaml:

autoDiscovery:
  clusterName: dev
rbac:
  serviceAccount:
    name: autoscaler
    annotations:
      eks.amazonaws.com/role-arn: arn:aws:iam::XXX:role/k8s-system-autoscaler-role

After applying configuration I do kubectl get sa/autoscaler -o yaml and see no annotation named eks.amazonaws.com/role-arn. That mean CA can't authenticate using OIDC provider and fails to start.

I expect Helm chart to add annotation eks.amazonaws.com/role-arn: arn:aws:iam::XXX:role/k8s-system-autoscaler-role to the SA autoscaler

[lexsys27]

Figured out the reason: due to https://github.com/kubernetes/autoscaler/issues/3318 I am using stable/cluster-autoscaler. And it require serviceAccountAnnotations instead of serviceAccount.annotations.

[gjtempleton]

Given the chart is now installable from here, is this issue OK to close?

[cabrinha]

Given the chart is now installable from here, is this issue OK to close?

Yes, I've tested on EKS with roles and it appears to be fine.

[gjtempleton]

Thanks for confirming!
/close

[k8s-ci-robot]

@gjtempleton: Closing this issue.

In response to this:

Thanks for confirming!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.