Autoscaler: Please release 1.2.4 with r5 support

Created on 6 Nov 2018 · 12Comments · Source: kubernetes/autoscaler

Recently 1.3.4 was released and includes support for a couple new aws instance types (r5, z1), it would be greatly appreciated if a similar release 1.2.4 could be made for those of us that will be still using kubernetes 1.10 for at least another couple months.

good first issue help wanted

Source

gwohletz

All 12 comments

Hi, this is currently blocked on #1346. Basically the tests on this branch are broken. I can revert the PR which caused this, but it would defeat the point as it's one of the two reasons 1.2.4 is requested at all.

aleksandra-malinowska on 7 Nov 2018

😕1

If this isn't going to be fixed for a while, it would be super useful to have a release that includes the r5 support.

gwohletz on 9 Nov 2018

Looks like #1478 resolve this issue?

Jeffwan on 6 Dec 2018

Is it possible to release only with r5 support?

spronin-aurea on 19 Dec 2018

👍1

Are you saying that you don't want the additional instance types beyond the "r5" family to be recognized by the autoscaler?

seh on 20 Dec 2018

Are you saying that you don't want the additional instance types beyond the "r5" family to be recognized by the autoscaler?

@seh if there is a PR already for all the instances newer than r5 - great, if not - I would certainly want to add just r5 support and get working autoscaler back.

spronin-aurea on 20 Dec 2018

I'm confused. Doesn't #1478 already include all the r5 family? Don't look at the types added there; look at the types that are already there.

Is the problem that this change has been committed, but there hasn't been a release that includes it?

seh on 21 Dec 2018

Exactly. It is not released yet. We have compiled our own version with this fix, but would be nice to have non-custom version.

spronin-aurea on 21 Dec 2018

@aleksandra-malinowska I'd like to help on v1.2.4 release. Looks like a few people #1556 want this change on Kubernetes 1.10. But I don't have permission. If there's a way for me to help, feel free to let me know. Thanks!

Jeffwan on 6 Jan 2019

Released 1.2.4: https://github.com/kubernetes/autoscaler/releases/tag/1.2.4

@Jeffwan thanks! We haven't migrated to fully automated cloud builds from github yet, so the process is kind of tricky for now. I think there's a release engineering effort to fix it, but there are no guidelines for setting it up for add-on components yet.

aleksandra-malinowska on 7 Jan 2019

@aleksandra-malinowska Thanks! The issue has a good first issue and then I thought I might be easy for contributors to make it. Now I get it.

Jeffwan on 7 Jan 2019

Right, sorry, this referred to fixing flaking tests.

aleksandra-malinowska on 7 Jan 2019

Was this page helpful?

0 / 5 - 0 ratings