Atrium: arrayAssertions for the new infix API

Created on 18 Oct 2019  路  9Comments  路  Source: robstoll/atrium

Platform (jvm, js, android): jvm
Extension (none, kotlin 1.3, jdk8): none

Code related feature

We want to migrate the api-cc-infix-en_GB... modules which are based on Assert to Expect. We have already created the corresponding
modules api-infix-en_GB.... Also there are already fluent-en_GB... modules where we have already done the transition from Assert to Expect

Following the things you need to do:

  • copy the file arrayAssertions.kt from atrium-api-fluent-en_GB-common to atrium-api-infix-en_GB-common

    • adjust the signatures of the assertion functions so that they are infix functions (see arrayAssertions.kt in atrium-api-cc-infix-en_GB-common for a guideline)

    • change since 0.9.0 to 0.11.0

  • copy the ArrayAsListAssertionsSpec.kt from atrium-api-fluent-en_GB-common to atrium-api-infix-en_GB-common

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime,
    we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
good first issue help wanted

All 9 comments

I'll work on this.

@Kshitij09 do you need help?

No. Was busy in exams.:sweat_smile: Will work on it now.

@Kshitij09 do you need help now?

Actually I'm getting busy in some other stuff. You may unassign me if it has to be implemented urgently. Otherwise, I'll work on it when get the time.

Un-assigning you, so that others can take over. You are welcome to come back and contribute any time (to this or another issue)

Sure :+1:

@robstoll I'll work on this

@isfedorov note that there is a difference between api-fluent and api-cc-infix. cc-infix still provides asIterable where fluent provides asList. Please add asList to the new infix api. Moreover, make also the functions which do not expect an assertionCreator infix by using the filler object o (as for notToBeNull o in anyAssertions.kt)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  4Comments

robstoll picture robstoll  路  3Comments

robstoll picture robstoll  路  6Comments

robstoll picture robstoll  路  3Comments