Atom: JS icon becomes JSX upon opening the file, even for files that do not contain JSX markup

Created on 21 Feb 2018  ·  2Comments  ·  Source: file-icons/atom

I'm using language-babel to transpile JavaScript, and I understand that Babel technically supports JSX in every file, but I expect only files that actually have JSX syntax to be shown as JSX, and preferably before actually opening the file.

I also anticipate it'd be hard to implement given how file icons are currently assigned based on filename and scope which for Babel is source.js.jsx.

js-jsx
_(the files in the GIF all contain JSX markup, but this happens for all the JS files similarly)_


atom --version

Atom    : 1.24.0
Electron: 1.6.16
Chrome  : 56.0.2924.87
Node    : 7.4.0
apm --version

apm  1.18.12
npm  3.10.10
node 6.9.5 x64
atom 1.24.0
python 2.7.10
git 2.9.3

apm ls

apm ls
Built-in Atom Packages (92)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

Community Packages (76) /Users/ivanbabak/.atom/packages
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
└── [email protected] (disabled)

duplicate

Most helpful comment

See https://github.com/file-icons/atom/issues/704#issuecomment-365807854. TL;DR: It was caused by a regression in Atom v1.24.0's code, which was fixed upstream after I reported it. The regression will vanish once the next patch release of Atom is out.

In the meantime, you can simply disable the grammar-strategy (uncheck the "Change on grammar override" option in the file-icons package settings).

I'm starting to think I should disable the strategy automatically for all v1.24.0 users (and for this version only). You're the fifth person to report this in a matter of days, and I can't imagine how many more users are currently confused as hell over this.

All 2 comments

See https://github.com/file-icons/atom/issues/704#issuecomment-365807854. TL;DR: It was caused by a regression in Atom v1.24.0's code, which was fixed upstream after I reported it. The regression will vanish once the next patch release of Atom is out.

In the meantime, you can simply disable the grammar-strategy (uncheck the "Change on grammar override" option in the file-icons package settings).

I'm starting to think I should disable the strategy automatically for all v1.24.0 users (and for this version only). You're the fifth person to report this in a matter of days, and I can't imagine how many more users are currently confused as hell over this.

@Alhadis Thanks, I should've searched in closed issues, too.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jgebhardt picture jgebhardt  ·  6Comments

carrodher picture carrodher  ·  3Comments

daltones picture daltones  ·  3Comments

radiocity picture radiocity  ·  3Comments

MaxGiting picture MaxGiting  ·  4Comments