Atom: Tab icon coloring

[mrleblanc101]

Hi,
I enabled VCS Coloring in atom-tab. Now my tab title are colored following their git status just like in tree-view.
The problem is the icons in the tab bar does not reflect the git status color like the one in the tab bar do.
Both icons in tree-view and atom-tab should reflect the same information, see screenshot for more details.

[Alhadis]

I can't reproduce this... it appears to be working fine for me, and with every combination of relevant settings.

@mrleblanc101, did you observe this shortly after installing or reactivating the package? If so, a restart is needed before some behaviour can function properly. It's a known issue.

[mrleblanc101]

Restarted Atom, changed git repository, changed file type, changed git status (modified instead of new) and still not working

[Alhadis]

Alright, then we've got problems.

First, I'll need you to provide me with a full list of packages that you have installed. You can produce one by running the command apm ls -lib in a terminal, and copy+pasting its output. It'd also help if we knew which UI theme you're using, and what OS and Atom version you're running.

(I really need to write an issue template...)

[mrleblanc101]

Atom version: 1.20.1 (latest stable)
macOS version: 10.13.1 (beta 1)
Theme: Atom material

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

[mrleblanc101]

From the developer tools, I see that the problem comes from this CSS overwriting the .status-modified color.

.amu-tinted-tab-bar atom-pane .tab-bar .tab .title[data-path]::before {
    color: rgba(255, 255, 255, 0.8) !important;
}
atom-pane .tab-bar .tab .title[data-path]::before {
    margin-right: 16px;
    color: rgba(131, 148, 150, 0.65) !important;
}

[mrleblanc101]

Seems like it comes from atom-material-ui/index.less

[Alhadis]

Looks like it's a known issue with the Atom Material theme. See atom-material/atom-material-ui#349.

Guess I'd better send 'em a pull-request...

[Alhadis]

@mrleblanc101 Are you using a variant of the atom-material theme, or is there some setting for enabling a dark-coloured motif I'm not seeing? (Apologies for my ignorance, I don't use the Material themes).

[mrleblanc101]

I'm pretty sure the text editor color is set by the syntax theme, not the ui theme.
In that case, it would be solarized dark.

[Alhadis]

Ah, that would explain everything, since I use a light-coloured theme. Thanks!

[mrleblanc101]

When is the next release with the fix ?

[Alhadis]

Hey @mrleblanc101,

I'm actually waiting for the next release of atom-material-ui, which will make available the fix I submitted in atom-material/atom-material-ui#439. The reason I've not cut a release yet is to catch any last-minute bug reports that might be submitted before there's a new theme release.

I apologise for not clarifying, I should've explained my inactivity a lot better. 😞

[Alhadis]

In other words, even if I make a new release now, you won't see the effects until another release of the Atom Material theme. You'll need to ask @silvestreh what his release cycle is like, I'm afraid.

[mrleblanc101]

Nah it's not your fault, it's alright.
I had an Atom Material update not long after I opened the issue so I thought the fix was already published.

[Alhadis]

Hasn't been a release since the 23rd of May, it seems. So it may have been another Material-related theme or package. :)

[silvestreh]

I'll push an update for Material UI 😄 … My baby was born last week, so my head's been everywhere but Github!

EDIT: Material UI 2.0.5 is up!

[Alhadis]

HAH! Trust us, we understand. :D Family first, mate. And congratulations on the new bundle, so to speak. =D

[Alhadis]

Thanks for pushing a new release, mate! 😀

@mrleblanc101 I'll cut a release soon-ish, I'm still trying to fix some weirdness with the spec-runner (Atom's prompting me to save a file as it's running tests, not really cool...).

[Alhadis]

Published and released in v2.1.13, please enjoy. =)