Hi all!
Using Atom 1.17.0 x64 (Mac), the spacing between the filenames and icons do not match the sidebar; they feel pretty crunched together. Here's an example of the sidebar:
And the top bar:
I believe they had a bit more space between them in previous versions, so maybe something with the Atom update messed with this a bit. Thanks!
zslabs
All 9 comments
Hey there,
That's strange. I'm running the same version and OS as you, but haven't noticed a difference in advance widths. Could you please tell me what theme you're using?
Alhadis
on 17 May 2017
Hi,
I'm using the One Dark theme (UI and syntax).
zslabs
on 17 May 2017
Same issue here
pezza3434
on 17 May 2017
Digging into this a bit more, it does look like there's a difference in spacing in the CSS.
Here's the sidebar:
And the top bar:
Kind of a weird mix of px and em, so possibly some core Atom styles changed?
zslabs
on 17 May 2017
Also, is it just me or have the panel tabs got a lot narrower?
pezza3434
on 17 May 2017
Same issue here.
justnealpatel
on 17 May 2017
Looks like this was deliberate. This part fell right on the money, too:
__Possible Drawbacks:__
This might override icon packages.
They've actually done the right thing; in fact, using em units is something this package should've been doing from day 1. Seems we're stuck with pixel measurements now... switching to em units would probably have pretty far-reaching consequences.
Anyway, the lack of breathing space is easily solved on our end:
~css
.tab-bar .tab .title:before{
width: 1em;
}
~
Result:
I'd prefer not to touch the icon-sizes, though. We shouldn't be fighting with theme styling anymore; and I'd prefer we avoid doing so, too. If you guys want to enlarge the icons, you can always crank the font-size of the icons with your stylesheets:
~css
.tab-bar .tab .title:before{
font-size: 1.5em; /* 鈥tc */
}
~
Alhadis
on 17 May 2017
This is probably worth releasing a hotfix for, since One Dark is such a commonly-used theme (and I hate to imagine how many users have already been bugged by this since Atom v1.17 was released).
Alhadis
on 17 May 2017
Okay, published! Sorry if that took too long...
Alhadis
on 17 May 2017
Related issues
carrodher
路
3Comments
Princeraul
路
3Comments
arielpontes
路
8Comments
gperdomor
路
3Comments
thisconnect
路
4Comments
Most helpful comment
Looks like this was deliberate. This part fell right on the money, too:
They've actually done the right thing; in fact, using
emunits is something this package should've been doing from day 1. Seems we're stuck with pixel measurements now... switching toemunits would probably have pretty far-reaching consequences.Anyway, the lack of breathing space is easily solved on our end:
~css.tab-bar .tab .title:before{
width: 1em;
}
~
Result:
I'd prefer not to touch the icon-sizes, though. We shouldn't be fighting with theme styling anymore; and I'd prefer we avoid doing so, too. If you guys want to enlarge the icons, you can always crank the
font-sizeof the icons with your stylesheets:~css.tab-bar .tab .title:before{
font-size: 1.5em; /* 鈥tc */
}
~