Atom: RSpec icons now the same as ruby icons

Created on 22 Mar 2017  路  9Comments  路  Source: file-icons/atom

I have just updated this package and all the icons under my spec folder in a Ruby project have changed to the red ruby gem icon. Previously they were the green RSpec icon.

Sorry if this is the wrong place to post this or there is a simply fix but I couldn't find anything about it.

Thanks

bug filetype-support styling

Most helpful comment

This will be resolved in the next release. If you still prefer the test-icon be green, add this to your stylesheet:

~less
.test-ruby-icon::before{
color: #90a959;
}
~

And if you prefer the plain old Ruby icon, coloured green:

~less
.test-ruby-icon::before{
font-family: "Octicons Regular";
content: "\f047";
font-size: 16px;
color: #90a959;
}
~

All 9 comments

I swear I wrote a comment on this thread, but it's disappeared.

@libbyschuknight Can you post a screenshot please? I don't know what "RSpec" you're referring to.

screen shot 2017-03-27 at 1 26 30 pm

This is a spec file, which is now showing the ruby icon. It use to show a green icon for the spec files, which I think did look a bit different. I can't upload an image of what it was like...

But this:
screen shot 2017-03-27 at 1 31 48 pm
This is what it was like and green.

Found this here https://github.com/file-icons/source/blob/master/charmap.md

馃槃

This is a recurring issue, I already reported something similar before in #483 and I confirm the same problem happens again with the latest release of this package.

I added a new icon for Ruby specs in the latest release:

Problem is, I forgot about specs in nested subdirectories. Meaning test/subdir/a-spec.rb won't show the new icon, but test/a-spec.rb will.

I could fix this, but you all seem so attached to just a plain Ruby icon, so now I don't know what to do.

Hey, I'm not attached to the plain Ruby icon! I for one would prefer to have a different icon and colour for the spec files. It was extremely useful to easily see the difference when having lots of files open.
Any reason you can't use the RSpec icon?

And by the way I think file-icons is great! I find it very useful! Thanks for all your hard work on it. 馃榾

Also, I just moved one of my spec files to be in the spec folder and yes it shows that new icon! Yay! I would love it if it could be green instead of red, so it is even more obviously different to a ruby file. I guess I am a sucker for keeping things as is once I discovered I really like something! 馃槀

I agree with @libbyschuknight. @Alhadis, we are attached to different color between source and spec/test... doesn't need to be the same icon. And the red/green combination was just perfect!

This will be resolved in the next release. If you still prefer the test-icon be green, add this to your stylesheet:

~less
.test-ruby-icon::before{
color: #90a959;
}
~

And if you prefer the plain old Ruby icon, coloured green:

~less
.test-ruby-icon::before{
font-family: "Octicons Regular";
content: "\f047";
font-size: 16px;
color: #90a959;
}
~

@Alhadis thank you!

Was this page helpful?
0 / 5 - 0 ratings