Atom-ide-ui: Outline view nesting issue

[damieng]

filterChangeWatchedFiles should be shown below TypeScriptLanguageClient not onDidConvertAutocomplete - the result payload looks like this;

This occurs in both 0.9.1 and 0.9.2 (and possibly earlier)

[laughedelic]

I can confirm that this occurred earlier. Can't say exactly, but for sure _before_ 0.9.0.

[laughedelic]

In fact, I found a screenshot dated by February 7, that I was going to use to report this (but then forgot 😅). So I think it was introduced in v0.8.0.

(here selected Scalafix symbol (and all following) should be on the same level as Scalafmt)

[damieng]

Hey @wbinnssmith any thoughts on this? It looks like the ol/li isn't nested in the dom so not sure what the intent was on how to identify the nesting here. Basically direct items beneath a branch have the same nesting as children below a peer. (getGrammarScopes, getLanguageName, getServerName and filterChangedWatchedFiles in my screenshot should all be considered the same 'level' as startServerProcess - not its children)

[matthewwithanm]

thanks for the report! looks like this is a simple repro:

class P:
    p = 1
    class K:
        k = 1

[wbinnssmith]

thanks @laughedelic @damieng @matthewwithanm !

going to look into this soon.

[laughedelic]

Here's another screenshot, which shows that the problem could be about rendering the list, not the nesting itself (that's why I opened #192 before):

In this outline the only misplaced items are highlighted, the red line shows that they are on the same level as autoImport in the code. And autoImport is placed correctly in the tree (with right indentation).

Notice also that the rest of the outline is correct: the Metals node has many children and they are all placed correctly.

[laughedelic]

Here is a better demo:

You see that x and y are aligned correctly, but appearance of the second level of nesting (foo.x.y) changes alignment of all other children.

[matthewwithanm]

this should be better in next week's release. thanks @peterhal for the fix!

[hansonw]

Will publish a release with https://github.com/facebook-atom/atom-ide-ui/commit/7a73f338342784cf4890363fcfb7209c08417c78 soon :)