Atom-ide-ui: Misplaced gutter icons

[TeeSeal]

Description

Gutter icons from the diagnostics module pop up to the left of line numbers. In fact, while no icons are visible it looks fine, as soon as a warning pops up, the whole line number row is moved to the right to make space for the icons. Not super important, but I find the way the linter package does it to be way more pleasant to the eye.

Expected Behavior

Actual Behavior

Versions

• Atom: 1.21.1
• Client OS: macOS High Sierra 10.13
• atom-ide-ui: 0.5.3

[Arcanemagus]

Just to note, the side of the line numbers that the linter-ui-default shows the indicators on is configurable.

[hansonw]

Yup, seems like a great configuration option / PR candidate! We've made this the default to play nicely with Nuclide's debugger functionality, which also puts breakpoints on the left - but I definitely see how the right side could be better for you. The gutters are created on https://github.com/facebook-atom/atom-ide-ui/blob/master/modules/atom-ide-ui/pkg/atom-ide-diagnostics-ui/lib/gutter.js#L83.

[TeeSeal]

Well, yeah linter-ui-default can be configured to place the icons on the left, but space for those icons is reserved from the get go, so they just appear in the reserved space.

With diagnostics however there is no space reserved from the beginning, and when it is needed it just changes the UI to make space, which weirds me out.

Even if that is fixed, it would still be nice to have an option to put the icons on the right.

[Arcanemagus]

With diagnostics however there is no space reserved from the beginning, and when it is needed it just changes the UI to make space, which weirds me out.

Ah, yea that's something that was fixed pretty early in linter-ui-default's development. A _lot_ of people don't like their UI jumping around on them 😛.

[phaux]

I changed the default behavior using custom style:

.gutter[gutter-name=diagnostics-gutter] {
  order: 1;
}