Atom-ide-ui: Table can get horribly out of alignment

[Arcanemagus]

Description

Somehow my Diagnostics panel table ended up in this state:

Atom was initially on a 1080x1920 monitor, dragging to a 1920x1080 monitor (and the subsequent relayout) didn't cause this to fix itself.

I have no idea how this happened so unfortunately I can't reproduce it, but I can get this table:

To turn into this:

By:

1. Causing all the diagnostic messages to be in the panel
2. Shrinking the horizontal space available to the panel to virtually nothing
3. Expanding the window to normal sizes again.

Expected Behavior

Table should stay aligned at all times.

Actual Behavior

Table is horribly misaligned.

Versions

• Atom: v1.22.0-beta0
• Client OS: Windows 10 x64
• atom-ide-ui: 0.4.0

Additional Details

Installed packages

Dev Packages (102) C:\Users\Landon Abney\.atom\dev\packages
├── [email protected]
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
└── [email protected]

Community Packages (102) C:\Users\Landon Abney\.atom\packages
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected] (disabled)
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] (disabled)
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

[hansonw]

@matthewwithanm I thought https://github.com/facebook-atom/atom-ide-ui/commit/5f56f6c95c4f348aa0e9c09f9162c883972d8b5d fixed this, but it's included in v0.4.0. Does this still happen? :(

[matthewwithanm]

Yeah, looking now.

[matthewwithanm]

Alright, so this is actually two issues. The first (alignment) was caused by an oversight of mine: we weren't recalculating the column widths when the columns changed. The second is a KP that I was procrastinating on. From the Table component:

// Update the column widths to account for minimum widths. This logic could definitely be
// improved. As it is now, if you resize the table to be very small and then make it large
// again, the proportions from when it was at its smallest will be preserved. If no
// columns have min widths, then this is what you want. But if a minimum width prevented
// one or more of the columns from shrinking, you'll probably consider them too wide when
// the table's expanded.

Fixes for both are in the queue now. They should land in master tomorrow and be in next week's release. 😊

[matthewwithanm]

Just realized I introduced another small column-resizing bug with my fix (columns can't be resized when the adjacent column is at its min width), but I'm going to go ahead with them and fix that after since it seems like a smaller issue.

[matthewwithanm]

k I fixed that too. All three should land tomorrow. 😊

[matthewwithanm]

Thanks so much for the detailed bug report and pictures @Arcanemagus!

💜

[Arcanemagus]

Thanks for mucking around in all that UI stuff and fixing it 😛.