Atom-beautify: Emacs not found

[francisjeanneau]

Continuation of #2186

Description

Emacs not working because of version number.
Emacs version: 26.1

The regex for Emacs version fails to find the string since the "patch" number does not exist.

src/beautifiers/vhdl-beautifier/index.coffee:19

        parse: (text) -> text.match(/Emacs (\d+\.\d+\.\d+)/)[1]

If you change the regex to:

        parse: (text) -> text.match(/Emacs (\d+\.\d+)/)[1]

It will fail at the semver.valid() call in

src/beautifiers/executable.coffee:94

        valid = Boolean(semver.valid(version))

Temporary fix

        parse: (text) -> text.match(/Emacs (\d+\.\d+)/)[1].concat ".0"

This case should surely be handled, no?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.

[francisjeanneau]

Still an issue

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.

[momostein]

I have this issue too
i'm using version 26.3

[samuelivarsson]

Still an issue
version 26.3

[francisjeanneau]

@samuelivarsson Maybe we'll need to open a new issue since this one's closed

[samuelivarsson]

Have you got it to work yet? @francisjeanneau

[francisjeanneau]

Have you got it to work yet? @francisjeanneau

I've stuck to the temporary fix I mentioned in the issue description (sorry it's been a while, I moved on to other projects)

[arnaudpladys]

Indeed this temporary fix work for me! Many thanks :)..

[swissbyte]

Thanks. This temporary fix works also for me.

[StefanK82]

This is still an issue. But the mentioned "temporary fix" worked for me using Ubuntu 20.04, Atom 1.48, Emacs 26.3 and atom-beautify 0.33.4 -- Thanks to francisjeanneau