Atlantis: Azure Devops - UI issue in comments

Created on 22 Nov 2019  路  4Comments  路  Source: runatlantis/atlantis

Now that things are working I noticed a minor UI issue when atlantis comments on the PR; it looks like azure devops doesn't support emojis so we see the alt text instead. Doesn't bother me but could make things look prettier:
bug

_Originally posted by @jimmyjamesbaldwin in https://github.com/runatlantis/atlantis/issues/849#issuecomment-557522955_

Opening an issue to research this further. I assumed that it was not supported either, but just found a recent Microsoft doc indicating that pull requests and wikis should support the full range of emojis now. So possibly there's an issue with the API version we're using in Atlantis pull request comments or maybe it has something to do with the blackfriday.v2 conversion we're doing before posting the comment.

azuredevops

Most helpful comment

IIRC, I added the blackfriday conversion early on when posting to Work Items instead of pull requests because the resulting comment formatting didn't look very good without it.

I just removed the conversion and the resulting comment actually looks a lot better now, and the emojis seem to work.

Screen Shot 2019-11-22 at 8 48 36 AM

I'll run with this for a bit and make sure there are no other issues with the workflow. If I don't run into any issues or hear any comments about why we should leave the blackfriday conversion in place, I will submit a PR to remove it.

All 4 comments

IIRC, I added the blackfriday conversion early on when posting to Work Items instead of pull requests because the resulting comment formatting didn't look very good without it.

I just removed the conversion and the resulting comment actually looks a lot better now, and the emojis seem to work.

Screen Shot 2019-11-22 at 8 48 36 AM

I'll run with this for a bit and make sure there are no other issues with the workflow. If I don't run into any issues or hear any comments about why we should leave the blackfriday conversion in place, I will submit a PR to remove it.

I think remove it!

Sounds good to me! I'll get something together.

@mcdafydd can you DM on Twitter (https://twitter.com/lkysow) or on the Atlantis Slack? I'd like to get in touch.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

timoguin picture timoguin  路  6Comments

natalysheinin picture natalysheinin  路  3Comments

teosoft123 picture teosoft123  路  5Comments

tlkamp picture tlkamp  路  5Comments

lkysow picture lkysow  路  6Comments