Atlantis: Azure DevOps Pull Request

[jpreese]

I saw that there was some hesitation around supporting Azure DevOps in issue #592, but was curious if this was an issue with the Atlantis team not having the capacity to implement it, and/or did not want to maintain the functionality at all.

A colleague is considering adding Azure DevOps support for Atlantis, but we wanted to check in with the team if its a PR you'd be willing to accept.

[mcdafydd]

I'll jump in. I reached out to Luke offline to ask this question as well. I have put in mostly working support in my repo's fork of Atlantis, but am not 100% ready to submit a PR. I'd love help collaborating and finishing that support. I started by forking the go-azuredevops repo and adding the necessary webhook processing support, and then bolting that into Atlantis.

https://github.com/mcdafydd/go-azuredevops/tree/master/azuredevops
https://github.com/mcdafydd/atlantis/tree/azure-devops

EDIT: We are also working on deploying this in a production environment, so we should have a good test-bed for validation in the coming couple weeks.

[jpreese]

Awesome! Atlantis is on our radar, but the lack of AzDO support was a limiting factor.

We'll definitely take a look at your fork. Please keep us updated!

[lkysow]

Hi John, it was both a capacity and maintenance issue. However if there's going to be community contributors that are willing to commit to maintaining the feature and triaging issues relating to it then I'm happy to review a pull request.

I'm wary of being in a situation where there is code in Atlantis that has security or urgent issues that I'm then on the hook to fix. This project has provided a strong guarantee for all of its code and I try to fix bugs/issues for existing features quickly.

If AZDO support is merged then I won't be able to do that (for azdo stuff) so I want to set expectations. I also don't want to be in a place where the AZDO feature causes a slow-down in bugfixing and feature development for the other parts of Atlantis. From what I've seen of mcdafydd's code I don't think it will cause those issues and I'm hoping that they're going to be able to maintain this feature going forward.

[jpreese]

hey @mcdafydd did you guys end up rolling this out to your production environment yet? If the code itself is relatively stable, I think creating a PR and getting the Atlantis guys involved would be a good idea so we can get it merged in.

[mcdafydd]

Greetings! Thanks for reaching out again. Actually, I think I'll be pushing the first production change through it later tonight. I have most of the tests passing and the first round of documentation updated. A couple small items left are:

• adding new tests for the azuredevops command-line flags
• deciding what to do about the relatively unknown go-azuredevops library in the vendor folder (I figured we could discuss this after submitting the PR)

I will try and get the command-line tests added and then submit the PR this week. I will shoot for before end of day tomorrow (Thursday). It may need a little cleaning up, but I'd love to get some extra eyeballs on it.

Thanks!

[jpreese]

Sounds awesome. Incredibly excited! Thanks for putting time into this.

[mcdafydd]

Added PR #719

You bet! I appreciate being given the opportunity.

[Marcus-James-Adams]

@mcdafydd Very interested in how you setup Atalantis with AzureDevOps, have you thought about putting together a medium or another blog on integrating it all and usage?

[lkysow]

Closed by #719